WordPress.org
Get WordPress

Make WordPress Core

Opened 9 years ago

Closed 6 years ago

Last modified 6 years ago

#43279 closed defect (bug) (fixed)

Form spacing is not equal both side on mobile for Add new user page

Reported by: jainnidhi Owned by: garrett-eclipse
Priority: normal Milestone: 5.5
Component: Users Version: 4.9.4
Severity: normal Keywords: has-patch commit
Cc: Focuses: ui, administration

Description

When we add a new user, form spacing is not equal on both side for mobile device.

Attachments (3)

spacing-on-mobile.png​ (72.3 KB ) - added by jainnidhi 9 years ago.
43279.diff​ (506 bytes ) - added by jainnidhi 9 years ago.
Screen Shot 2020-04-20 at 11.06.40 PM.png​ (627.0 KB ) - added by garrett-eclipse 6 years ago.
Patch Test - Add New User form with same spacing on either side.

Download all attachments as: .zip

Change History (10)

@jainnidhi
9 years ago

@jainnidhi
9 years ago

#1 @jainnidhi
9 years ago

  • Keywords has-patch added

I've attached 43279.diff for this fix.

#2 @garrett-eclipse
7 years ago

  • Component General → Users
  • Keywords needs-design-feedback added

Thanks for the patch @jainnidhi I can reproduce the issue and the patch looks good. Moving it into the Users component for review and action. Also marking for design review to just get a second set of eyes and confirm on the UI change.

This ticket was mentioned in ​Slack in #design by estelaris. ​View the logs.
6 years ago

#4 @ibdz
6 years ago

  • Keywords needs-design-feedback removed

In ​design triage today, we agreed to remove the right padding of the form, make equal spacing on both sides.

#5 @garrett-eclipse
6 years ago

  • Focuses administration added
  • Keywords commit added
  • Milestone Awaiting Review → 5.5
  • Owner set to garrett-eclipse
  • Status new → accepted

Thanks @ibdz and the rest of the design team for taking a look. Retesting the patch it's applying and resolving the issue nicely.
Going to move to a committer review for 5.5. Thanks again for the patch @jainnidhi and congratulations on your first contribution.

@garrett-eclipse
6 years ago

Patch Test - Add New User form with same spacing on either side.

#6 @SergeyBiryukov
6 years ago

  • Resolution → fixed
  • Status accepted → closed

In 47622:

Administration: Remove right padding on form tables on smaller screens so that the spacing is equal on both sides.

Additionally, reduce the right margin on screen meta links (Help and Screen Options) to align with the tables.

Props jainnidhi, garrett-eclipse, ibdz, SergeyBiryukov.
Fixes #43279.

#7 @garrett-eclipse
6 years ago

Good catch on the screen meta links @SergeyBiryukov

Note: See TracTickets for help on using tickets.