WordPress.org

Make WordPress Core

Opened 3 years ago

Closed 7 months ago

Last modified 7 months ago

#43279 closed defect (bug) (fixed)

Form spacing is not equal both side on mobile for Add new user page

Reported by: jainnidhi Owned by: garrett-eclipse
Milestone: 5.5 Priority: normal
Severity: normal Version: 4.9.4
Component: Users Keywords: has-patch commit
Focuses: ui, administration Cc:

Description

When we add a new user, form spacing is not equal on both side for mobile device.

Attachments (3)

spacing-on-mobile.png (72.3 KB) - added by jainnidhi 3 years ago.
43279.diff (506 bytes) - added by jainnidhi 3 years ago.
Screen Shot 2020-04-20 at 11.06.40 PM.png (627.0 KB) - added by garrett-eclipse 7 months ago.
Patch Test - Add New User form with same spacing on either side.

Download all attachments as: .zip

Change History (10)

@jainnidhi
3 years ago

#1 @jainnidhi
3 years ago

  • Keywords has-patch added

I've attached 43279.diff for this fix.

#2 @garrett-eclipse
17 months ago

  • Component changed from General to Users
  • Keywords needs-design-feedback added

Thanks for the patch @jainnidhi I can reproduce the issue and the patch looks good. Moving it into the Users component for review and action. Also marking for design review to just get a second set of eyes and confirm on the UI change.

This ticket was mentioned in Slack in #design by estelaris. View the logs.


7 months ago

#4 @ibdz
7 months ago

  • Keywords needs-design-feedback removed

In design triage today, we agreed to remove the right padding of the form, make equal spacing on both sides.

#5 @garrett-eclipse
7 months ago

  • Focuses administration added
  • Keywords commit added
  • Milestone changed from Awaiting Review to 5.5
  • Owner set to garrett-eclipse
  • Status changed from new to accepted

Thanks @ibdz and the rest of the design team for taking a look. Retesting the patch it's applying and resolving the issue nicely.
Going to move to a committer review for 5.5. Thanks again for the patch @jainnidhi and congratulations on your first contribution.

@garrett-eclipse
7 months ago

Patch Test - Add New User form with same spacing on either side.

#6 @SergeyBiryukov
7 months ago

  • Resolution set to fixed
  • Status changed from accepted to closed

In 47622:

Administration: Remove right padding on form tables on smaller screens so that the spacing is equal on both sides.

Additionally, reduce the right margin on screen meta links (Help and Screen Options) to align with the tables.

Props jainnidhi, garrett-eclipse, ibdz, SergeyBiryukov.
Fixes #43279.

#7 @garrett-eclipse
7 months ago

Good catch on the screen meta links @SergeyBiryukov

Note: See TracTickets for help on using tickets.