WordPress.org

Make WordPress Core

Opened 22 months ago

Last modified 3 weeks ago

#43287 new enhancement

The text "immediately" should be capitalize in publish meta box.

Reported by: jainnidhi Owned by:
Milestone: Awaiting Review Priority: normal
Severity: normal Version: 4.9.4
Component: Posts, Post Types Keywords: has-patch
Focuses: ui, administration Cc:
PR Number:

Description

If we see in the "Publish" metabox, Status and Visibility texts are capitalize. So "immediately" text should also be capitalize.

Attachments (5)

43287.diff (2.0 KB) - added by jainnidhi 22 months ago.
capitalize-text-issue.png (48.8 KB) - added by jainnidhi 22 months ago.
43287.1.diff (2.0 KB) - added by jainnidhi 22 months ago.
43287.2.diff (1.1 KB) - added by gb_jlm 12 months ago.
Updated /wp-admin/includes/meta-boxes.php since the code has changed since the last patch was attached to this ticket.
Screen Shot 2018-12-21 at 22.58.17 .png (43.1 KB) - added by gb_jlm 12 months ago.
Screenshot of “Publish: Immediately” after code changes

Download all attachments as: .zip

Change History (15)

@jainnidhi
22 months ago

#1 @jainnidhi
22 months ago

  • Keywords has-patch added

#2 @xkon
22 months ago

  • Keywords ui-feedback added

I see in your diff that you changed it to Publish Immediately.

Everything else also has : between the title : outcome. So maybe it should be Publish: Immediately to be more inline with the other options and to make sense why it is capitalized as well.

Also an extra thought would be to not change the title completely from Publish to Schedule for: <date> but instead from Publish: to Publish on: <date> maybe ?

@jainnidhi
22 months ago

#3 @jainnidhi
22 months ago

Yes @xkon. I missed the colon.
So I've attached the patch for this fix.

#4 @SergeyBiryukov
22 months ago

  • Component changed from General to Posts, Post Types
  • Focuses administration added

This ticket was mentioned in Slack in #design by karmatosed. View the logs.


12 months ago

#6 @gb_jlm
12 months ago

I’ll load this patch and confirm visually by the end of this week.

@gb_jlm
12 months ago

Updated /wp-admin/includes/meta-boxes.php since the code has changed since the last patch was attached to this ticket.

@gb_jlm
12 months ago

Screenshot of “Publish: Immediately” after code changes

#7 @gb_jlm
12 months ago

This is the first time I’ve ever made a patch, so I’m not sure if I did it correctly, but the old patch wouldn’t load because of the changes to core since the patch.

This ticket was mentioned in Slack in #design by gb_jlm. View the logs.


11 months ago

This ticket was mentioned in Slack in #design by karmatosed. View the logs.


3 weeks ago

#10 @michaelarestad
3 weeks ago

  • Keywords ui-feedback removed

Nice change. From a design standpoint, it's good to go. If it works, it is good to go.

Note: See TracTickets for help on using tickets.