WordPress.org

Make WordPress Core

Opened 10 years ago

Closed 10 years ago

Last modified 10 years ago

#4329 closed defect (bug) (fixed)

RSD-Generated API Links broken when site != url

Reported by: redsweater Owned by: josephscott
Milestone: 2.2.1 Priority: normal
Severity: normal Version: 2.2
Component: XML-RPC Keywords:
Focuses: Cc:

Description

A MarsEdit customer discovered a bug with his WordPress installation's RSD content. For WordPress installations where the wordpress directory differs from the blog URL direcdtory, the RSD file generated by WordPress contains xmlrpc.php URLs that point to the wrong place.

The bug is in xmlrpc.php, where URLs for pointing at xmlrpc.php are generated, e.g.:

<api name="Movable Type" blogID="1" preferred="true" apiLink="<?php bloginfo_rss('url') ?>/xmlrpc.php" />

I believe the bloginfo_rss line should actually be looking up "wpurl" instead of "url".

The funny thing is, a nearly identical bug caused the RSD link to not be found in this circumstance, but was fixed:

http://trac.wordpress.org/ticket/2349

Of course, now it finds the RSD - it's just full of useless URLs :)

The customer noticed this on WP 2.2, but I believe it's been around forever. Note in the initial RSD checkin, all the "bloginfo" keys are "url":

http://trac.wordpress.org/changeset/3009

The ticket linked above fixed the problem for the link TO the rsd, but not for the links generated by the RSD.

Attachments (1)

xmlrpc.php-diff (1.2 KB) - added by josephscott 10 years ago.

Download all attachments as: .zip

Change History (7)

#1 @rob1n
10 years ago

I think the xmlrpc.php is supposed to be in the same directory as the index.php.

#2 @redsweater
10 years ago

If that's true then the previous fix (2349) was wrong, right?

#3 @foolswisdom
10 years ago

  • Owner changed from anonymous to josephscott

Confirmed bug on trunk.

#4 @josephscott
10 years ago

My diff adjusts all of the API links to use bloginfo_rss('wpurl') instead of bloginfo_rss('url'). For blogs with where home == siteurl this is effectively a no-op.

#5 @ryan
10 years ago

  • Resolution set to fixed
  • Status changed from new to closed

(In [5537]) RSD link fixes from Joseph Scott. fixes #4329 for 2.3

#6 @ryan
10 years ago

(In [5538]) RSD link fixes from Joseph Scott. fixes #4329 for 2.2

Note: See TracTickets for help on using tickets.