Make MagpieRSS use UTF-8 as default encoding

[nbachiyski]

If not set explicitly, php xml functions will use the default encoding in php, which usually is latin1 and thus breaks (shows question marks) some rss feeds.

For more information: ​http://php.net/manual/en/ref.xml.php#xml.encoding

[rob1n]

From ​http://us.php.net/manual/en/function.xml-parser-create.php:

If empty string is passed, the parser attempts to identify which encoding the document is encoded in by looking at the heading 3 or 4 bytes.

Maybe just pass an empty string?

[nbachiyski]

Empty string didn't work well.

Here is the test case I used:

• Feed: ​http://del.icio.us/rss/humperdink/cyrtitle
• RSS Widget

on PHP 4.10 (Debian, CGI).

[Denis-de-Bernardy]

​http://us.php.net/manual/en/function.xml-parser-create.php

"The optional encoding specifies the character encoding for the input/output in PHP 4. Starting from PHP 5, the input encoding is automatically detected, so that the encoding parameter specifies only the output encoding. In PHP 4, the default output encoding is the same as the input charset. If empty string is passed, the parser attempts to identify which encoding the document is encoded in by looking at the heading 3 or 4 bytes. In PHP 5.0.0 and 5.0.1, the default output charset is ISO-8859-1, while in PHP 5.0.2 and upper is UTF-8. The supported encodings are ISO-8859-1, UTF-8 and US-ASCII."

Imo, UTF-8 is the better default.

[Denis-de-Bernardy]

reattaching patch

[ryan]

We now use SimplePie. see #9198