WordPress.org
Get WordPress

Make WordPress Core

Opened 9 years ago

Closed 9 years ago

#43307 closed defect (bug) (fixed)

Error wp-admin > Includes > theme.php

Reported by: nandorsky Owned by: SergeyBiryukov
Priority: normal Milestone: 4.9.5
Component: Customize Version: 4.9
Severity: normal Keywords: has-patch fixed-major
Cc: Focuses:

Description

Hi,

I'm getting errors in my PHP editor for this file: wp-admin > Includes > theme.php
Looks like 2 Button tags at the bottom are not closed properly. Possible ?

<button type="button" class="button button-primary customize-theme"><?php _e( 'Customize' ); ?></a>
<button type="button" class="button button-primary preview-theme" data-slug="{{ data.id }}"><?php _e( 'Live Preview' ); ?></span>

Attachments (1)

43307.diff​ (1.4 KB ) - added by johnpgreen 9 years ago.

Download all attachments as: .zip

Change History (6)

@johnpgreen
9 years ago

#1 @johnpgreen
9 years ago

  • Keywords has-patch added

#2 @SergeyBiryukov
9 years ago

  • Component Administration → Customize
  • Milestone Awaiting Review → 4.9.5
  • Version 4.9.4 → 4.9

Introduced in [41648].

#3 @SergeyBiryukov
9 years ago

  • Owner set to SergeyBiryukov
  • Resolution → fixed
  • Status new → closed

In 42711:

Customize: Correct closing tags in customize_themes_print_templates().

Props johnpgreen, nandorsky.
Fixes #43307.

#4 @SergeyBiryukov
9 years ago

  • Keywords fixed-major added
  • Resolution fixed
  • Status closed → reopened

Reopening for 4.9.5 consideration.

#5 @SergeyBiryukov
9 years ago

  • Resolution → fixed
  • Status reopened → closed

In 42803:

Customize: Correct closing tags in customize_themes_print_templates().

Props johnpgreen, nandorsky.
Merges [42711] to the 4.9 branch.
Fixes #43307.

Note: See TracTickets for help on using tickets.