WordPress.org

Make WordPress Core

Opened 3 months ago

Closed 3 months ago

#43307 closed defect (bug) (fixed)

Error wp-admin > Includes > theme.php

Reported by: nandorsky Owned by: SergeyBiryukov
Milestone: 4.9.5 Priority: normal
Severity: normal Version: 4.9
Component: Customize Keywords: has-patch fixed-major
Focuses: Cc:

Description

Hi,

I'm getting errors in my PHP editor for this file: wp-admin > Includes > theme.php Looks like 2 Button tags at the bottom are not closed properly. Possible ?

<button type="button" class="button button-primary customize-theme"><?php _e( 'Customize' ); ?></a> <button type="button" class="button button-primary preview-theme" data-slug="{{ data.id }}"><?php _e( 'Live Preview' ); ?></span>

Attachments (1)

43307.diff (1.4 KB) - added by johnpgreen 3 months ago.

Download all attachments as: .zip

Change History (6)

@johnpgreen
3 months ago

#1 @johnpgreen
3 months ago

  • Keywords has-patch added

#2 @SergeyBiryukov
3 months ago

  • Component changed from Administration to Customize
  • Milestone changed from Awaiting Review to 4.9.5
  • Version changed from 4.9.4 to 4.9

Introduced in [41648].

#3 @SergeyBiryukov
3 months ago

  • Owner set to SergeyBiryukov
  • Resolution set to fixed
  • Status changed from new to closed

In 42711:

Customize: Correct closing tags in customize_themes_print_templates().

Props johnpgreen, nandorsky.
Fixes #43307.

#4 @SergeyBiryukov
3 months ago

  • Keywords fixed-major added
  • Resolution fixed deleted
  • Status changed from closed to reopened

Reopening for 4.9.5 consideration.

#5 @SergeyBiryukov
3 months ago

  • Resolution set to fixed
  • Status changed from reopened to closed

In 42803:

Customize: Correct closing tags in customize_themes_print_templates().

Props johnpgreen, nandorsky.
Merges [42711] to the 4.9 branch.
Fixes #43307.

Note: See TracTickets for help on using tickets.