WordPress.org

Make WordPress Core

Changes between Initial Version and Version 1 of Ticket #43316, comment 91


Ignore:
Timestamp:
06/21/2018 05:04:18 PM (3 years ago)
Author:
azaozz
Comment:

Legend:

Unmodified
Added
Removed
Modified
  • Ticket #43316, comment 91

    initial v1  
    1414> 2. Because we delete the revision and then return immediately with an error, isn't it true that we're not simply not storing redundant revision, we're in fact destroying a revision without having anything new to serve in its place?
    1515
    16 Yes, that's true. Technically there is no reason to delete the old autosave revision. Even then, what should be returned for such requests? Seems we have to return the "old" autosave ID? Then the autosave revision content will be different from the submitted content.
     16Yes, technically there is no reason to delete the old autosave revision. Even then, what should be returned for such requests? Seems we have to return the "old" autosave ID? Then the autosave revision content will be different from the submitted content.
    1717
    1818Another option is to standardize on always returning the post_ID of the actual post being edited. Currently this is the case for drafts (same user) when the post is updated, but the returned ID is the autosave revision ID when draft for different user or published post. Thinking it will probably be best to always return the "real" post_ID for all autosave requests.