New filter suggestion for manage_users-network_custom_column

[lenasterg]

Hi.
In a multisite installation, currently a custom column for the users list table uses the filter 'manage_users_custom_column' for both network users admin table and single subsite users admin table.
https://core.trac.wordpress.org/browser/trunk/src/wp-admin/includes/class-wp-ms-users-list-table.php#L398

This is a bit confusing for plugin development since all the other filters and actions used in the network users admin table are based on the $screen->id, which for the network users admin page is "users-network".
For example the filters: "manage_users-network_columns" and "manage_users-network_sortable_columns"

The attached is a suggestion for introducing the filter 'manage_users-network_custom_column', without dropping the support for 'manage_users_custom_colunm.

[realloc]

The suggestion looks good to me! What are your thoughts on taking it a step further by using ​apply_filters_deprecated for the first hook?

[lenasterg]

Replying to realloc:

The suggestion looks good to me! What are your thoughts on taking it a step further by using ​apply_filters_deprecated for the first hook?

Sounds nice, but which WordPress version should I use as $version in apply_filters_deprecated()?
I have no idea IF and in which WordPress version, the new filter suggestion would be accepted.

[realloc]

I would set the current version. This information can be set later on, if needed.

[lenasterg]

Replying to realloc:

I would set the current version. This information can be set later on, if needed.

Perhaps the committer could handle this? I am unsure of the correct approach.

https://core.trac.wordpress.org/ticket/43318

[audrasjb]

@lenasterg I refreshed the proposed patch. What do you think?

[lenasterg]

Yes, I agree the changes make it more understandable, thank you for the update.

Replying to audrasjb:

@lenasterg I refreshed the proposed patch. What do you think?

[audrasjb]

In 59878:

Comments: Remove bulk action dropdown depending on user caps.

This changeset introduces the manage_users-network_custom_column filter that fires for each custom column in the Network Users list table. This is an override hook for manage_users_custom_column which was already filtering each custom column in all Users list tables.

Props lenasterg, realloc, audrasjb.
Fixes #43318.