Opened 7 years ago
Last modified 7 days ago
#43318 new enhancement
New filter suggestion for manage_users-network_custom_column
Reported by: |
|
Owned by: | |
---|---|---|---|
Milestone: | 6.8 | Priority: | normal |
Severity: | normal | Version: | |
Component: | Users | Keywords: | has-patch |
Focuses: | multisite | Cc: |
Description
Hi.
In a multisite installation, currently a custom column for the users list table uses the filter 'manage_users_custom_column' for both network users admin table and single subsite users admin table.
https://core.trac.wordpress.org/browser/trunk/src/wp-admin/includes/class-wp-ms-users-list-table.php#L398
This is a bit confusing for plugin development since all the other filters and actions used in the network users admin table are based on the $screen->id, which for the network users admin page is "users-network".
For example the filters: "manage_users-network_columns" and "manage_users-network_sortable_columns"
The attached is a suggestion for introducing the filter 'manage_users-network_custom_column', without dropping the support for 'manage_users_custom_colunm.
Attachments (1)
Change History (9)
This ticket was mentioned in Slack in #core-multisite by lenasterg. View the logs.
5 weeks ago
#4
in reply to:
↑ 3
@
4 weeks ago
Replying to realloc:
The suggestion looks good to me! What are your thoughts on taking it a step further by using apply_filters_deprecated for the first hook?
Sounds nice, but which WordPress version should I use as $version in apply_filters_deprecated()?
I have no idea IF and in which WordPress version, the new filter suggestion would be accepted.
#5
follow-up:
↓ 6
@
4 weeks ago
I would set the current version. This information can be set later on, if needed.
#6
in reply to:
↑ 5
@
10 days ago
Replying to realloc:
I would set the current version. This information can be set later on, if needed.
Perhaps the committer could handle this? I am unsure of the correct approach.
The suggestion looks good to me! What are your thoughts on taking it a step further by using apply_filters_deprecated for the first hook?