#43333 closed defect (bug) (fixed)
Unable to add menu item
Reported by: |
|
Owned by: |
|
---|---|---|---|
Milestone: | 4.9.5 | Priority: | normal |
Severity: | normal | Version: | 4.3 |
Component: | Customize | Keywords: | has-patch commit fixed-major |
Focuses: | ui, javascript | Cc: |
Description
Hi,
well i was trying to use the menu builder on the Customizer. And while i was trying to search a menu from the search field after having clicked "add items", then i pressed the "esc" button (Windows) and the menu items panel closed, when i clicked again on "Add items"... the panel was empty... i have to click on the cross within the search field to reveal the menu items.
Here is a video which shows the issue
http://nimb.ws/QPu0DM
Attachments (2)
Change History (14)
#3
@
7 years ago
- Keywords needs-refresh added
Hi @aranwer104 - thanks for the patch. I tested your patch out and I now see that the search field is empty - however the list of results is not repopulated as expected. Here is a screencast of my test: https://cl.ly/0a3o2a3O0z12
Are you seeing something different?
#4
follow-up:
↓ 7
@
7 years ago
- Keywords reporter-feedback added; needs-refresh removed
- Owner set to adamsilverstein
- Status changed from new to assigned
It looks like what is needed here is triggering a keyup event when the field is cleared, this triggers the search and thur resets the results. In my testing 43333.diff fixes the issue.
@aranwer104 or @Blair jersyer - can you test out this approach and see if anything looks off to you after the search reset?
#5
@
7 years ago
- Milestone changed from Awaiting Review to 5.0
- Version changed from 4.8.3 to 4.3
I verified this issue has existed since menus in the customizer was introduced in WordPress 4.3.
#6
@
7 years ago
Since i'm not a member of the core, how can i download and test your changes @adamsilverstein ?
#7
in reply to:
↑ 4
@
7 years ago
- Keywords ux-feedback added
Replying to adamsilverstein:
@aranwer104 or @Blair jersyer - can you test out this approach and see if anything looks off to you after the search reset?
Hi @adamsilverstein Your patch works perfectly (on Windows).Triggering keyup was an elegant and simple solution.
#8
@
7 years ago
- Keywords commit added; reporter-feedback ux-feedback removed
- Milestone changed from 5.0 to 4.9.5
@aranwer104 great - thanks for testing!
@Blair jersyer - you really need to have a local setup to test this, in your local setup you would apply the diff I uploaded using the patch command. Here is an introduction to this (which is itself a work in progress): https://make.wordpress.org/core/handbook/testing/patch/
In any case, I think we have a confirmed fix - once we get this committed to core you can test it in the next release of WordPress.
Can reproduce on current trunk. Seems when the panel closes, the filtering of the available menu items is not reset.