Make WordPress Core

Opened 6 years ago

Closed 3 months ago

#43342 closed enhancement (wontfix)

Twenty Seventeen: Add m.me (Messenger) icon to supported social media links

Reported by: binki's profile binki Owned by:
Milestone: Priority: low
Severity: normal Version:
Component: Bundled Theme Keywords: has-patch needs-refresh close
Focuses: ui Cc:

Description

If I include a link starting with https://m.me/ in my social media menu, it doesn’t show a messenger icon. It instead shows as a generic link icon.

I have attempted to create an icon for this and registered it so that the theme knows to use it for these links. It’s better than what wordpress shows currently.

Please see attached patch.

Attachments (1)

wordpress-r42716-twentyseventeen-add-messenger-icon.patch (1.5 KB) - added by binki 6 years ago.

Download all attachments as: .zip

Change History (10)

#1 @binki
6 years ago

Example of icon in use:

https://i.imgur.com/Bs3GPjj.png

#2 @dingo_bastard
6 years ago

  • Component changed from Themes to Bundled Theme
  • Keywords dev-feedback added

#3 @SergeyBiryukov
6 years ago

  • Summary changed from Add m.me (Messenger) icon to twentyseventeen’s supported social media links to Twenty Seventeen: Add m.me (Messenger) icon to supported social media links

#4 @pento
5 years ago

  • Version trunk deleted

#5 @sabernhardt
3 years ago

  • Keywords has-patch needs-refresh added

Thanks for the ticket and the patch!

The Messenger icon has been revised since 2019, so the patch would need a refresh.
https://en.facebookbrand.com/

Also, if we add Messenger, we probably should update the Facebook icon as well.

#6 @sabernhardt
3 years ago

  • Keywords close 2nd-opinion added

Requests for new Twenty Twenty icons were closed last year, in favor of creating a filter (see ticket:48713#comment:7), so perhaps this should be closed as well.

Kinsta describes how to use the Twenty Seventeen filter for any additional SVG icons.

#7 @sabernhardt
3 years ago

  • Keywords changed from dev-feedback, has-patch, needs-refresh, close, 2nd-opinion to dev-feedback has-patch needs-refresh close 2nd-opinion

If we decide not to add Messenger, the Facebook icon may still be worth updating.

#8 @desrosj
2 years ago

  • Keywords dev-feedback 2nd-opinion removed
  • Priority changed from normal to low

I agree on the decision to not add Messenger.

Updating the Facebook icon seems reasonable. Might want to confirm all of the icons are current while we are at it. But I'd say this is a low priority task, so leaving as a close candidate.

#9 @karmatosed
3 months ago

  • Milestone Awaiting Review deleted
  • Resolution set to wontfix
  • Status changed from new to closed

As has been advised to close this I am going to follow that through and do just that. I will note that the comments of updating the icon on Facebook being made into another ticket still can be done even if this is closed. Thank you everyone for your collaboration on this ticket so far.

Note: See TracTickets for help on using tickets.