WordPress.org

Make WordPress Core

Opened 4 years ago

Last modified 3 months ago

#43342 new enhancement

Twenty Seventeen: Add m.me (Messenger) icon to supported social media links

Reported by: binki Owned by:
Milestone: Awaiting Review Priority: normal
Severity: normal Version:
Component: Bundled Theme Keywords: dev-feedback has-patch needs-refresh close 2nd-opinion
Focuses: ui Cc:

Description

If I include a link starting with ​https://m.me/ in my social media menu, it doesn’t show a messenger icon. It instead shows as a generic link icon.

I have attempted to create an icon for this and registered it so that the theme knows to use it for these links. It’s better than what wordpress shows currently.

Please see attached patch.

Attachments (1)

wordpress-r42716-twentyseventeen-add-messenger-icon.patch​ (1.5 KB) - added by binki 4 years ago.

Download all attachments as: .zip

Change History (8)

@binki
4 years ago

#1 @binki
4 years ago

Example of icon in use:

https://i.imgur.com/Bs3GPjj.png

#2 @dingo_bastard
4 years ago

  • Component changed from Themes to Bundled Theme
  • Keywords dev-feedback added

#3 @SergeyBiryukov
3 years ago

  • Summary changed from Add m.me (Messenger) icon to twentyseventeen’s supported social media links to Twenty Seventeen: Add m.me (Messenger) icon to supported social media links

#4 @pento
3 years ago

  • Version trunk deleted

#5 @sabernhardt
5 months ago

  • Keywords has-patch needs-refresh added

Thanks for the ticket and the patch!

The Messenger icon has been revised since 2019, so the patch would need a refresh.
​https://en.facebookbrand.com/

Also, if we add Messenger, we probably should update the Facebook icon as well.

#6 @sabernhardt
3 months ago

  • Keywords close 2nd-opinion added

Requests for new Twenty Twenty icons were closed last year, in favor of creating a filter (see ticket:48713#comment:7), so perhaps this should be closed as well.

Kinsta describes ​how to use the Twenty Seventeen filter for any additional SVG icons.

#7 @sabernhardt
3 months ago

  • Keywords changed from dev-feedback, has-patch, needs-refresh, close, 2nd-opinion to dev-feedback has-patch needs-refresh close 2nd-opinion

If we decide not to add Messenger, the Facebook icon may still be worth updating.

Note: See TracTickets for help on using tickets.