WordPress.org

Make WordPress Core

Opened 20 months ago

Closed 20 months ago

Last modified 20 months ago

#43343 closed defect (bug) (invalid)

Comparison operators " ! " is not used in same way. should be same.

Reported by: anilhada Owned by:
Milestone: Priority: normal
Severity: normal Version: 4.9.4
Component: General Keywords:
Focuses: coding-standards Cc:
PR Number:

Description

Code structure should be same.

In admin.php file. See line number 215 ...... if (! isset($_GETnoheader?))

and

In admin.php file. See line number 247 ..... if ( !isset($_GETnoheader?))

Change History (3)

#1 @audrasjb
20 months ago

Hi and welcome !

I guess you need to update your WP core test version to trunk: http://core.svn.wordpress.org/trunk/
I don’t see any difference between these two lines (in trunk, L. 229 & 263), it is correct in both cases :)

Cheers,
Jb

#2 @audrasjb
20 months ago

  • Resolution set to invalid
  • Status changed from new to closed

#3 @netweb
20 months ago

  • Milestone Awaiting Review deleted

Thanks for the ticket @anilhada, as @audrasjb has alluded to this has since been fixed, in fact, it was fixed in [42343] and will ship as part of the upcoming WordPress 5.0

Note: See TracTickets for help on using tickets.