$wp_locale->start_of_week is always NULL

[tonybogdanov]

It seems that the start_of_week property of class WP_Locale (introduced in version 4.4) always resolves to NULL, because it is never initialized (determined by a quick global search for ->start_of_week).

It also seems like the rest of the codebase only relies on get_option('start_of_week'), including tests, thus nothing is really affected (seemingly) by the bug.

Perhaps someone just forgot to add $this->start_of_week = get_option('start_of_week'); in init()?

[birgire]

Nice findings @tonybogdanov

I did some digging:

This was introduced in changeset [35336] for the ticket Remove "Week Starts On" setting UI #28344.

That ticket was then closed with a wontfix with new code additions reverted in changeset [35685], but the newly added property definition:

/**
 * Stores the default start of the week.
 *
 * @since 4.4.0
 * @var string
 */
 public $start_of_week;

was not reverted as expected.

So I would suggest to remove it, from the WP_Locale class, as it's not used anywhere and should have been removed in [35685].

This part is removed in 43344.diff​.

[birgire]

hmm, I didn't meant to close this as invalid, so I reopen the ticket ;-)

[ocean90]

In 42718:

I18N: Remove unused $start_of_week property from WP_Locale.

Missed in [35685], see #28344.

Props birgire, tonybogdanov.
Fixes #43344.