WordPress.org

Make WordPress Core

Opened 4 years ago

Closed 4 years ago

Last modified 2 years ago

#43346 closed enhancement (fixed)

Fix code indent in unescape_invalid_shortcodes()

Reported by: joelcj91 Owned by: SergeyBiryukov
Milestone: 5.1 Priority: normal
Severity: normal Version: 4.3
Component: Shortcodes Keywords: has-patch commit
Focuses: coding-standards Cc:

Description

In wp-includes/shortcodes.php file, the unescape_invalid_shortcodes function is not properly indented.

Attachments (2)

43346.patch (712 bytes) - added by joelcj91 4 years ago.
Fix code indent
43346.2.patch (710 bytes) - added by joelcj91 4 years ago.
Fix code indent (correction)

Download all attachments as: .zip

Change History (11)

@joelcj91
4 years ago

Fix code indent

#1 follow-up: @GaryJ
4 years ago

Thanks, @joelcj91.

Since the $content assignment now has a clear line before it, the = for the previous assignment does not need to be aligned (i.e. remove the extra space before the =.

@joelcj91
4 years ago

Fix code indent (correction)

#2 in reply to: ↑ 1 @joelcj91
4 years ago

Replying to GaryJ:

Thanks, @joelcj91.

Since the $content assignment now has a clear line before it, the = for the previous assignment does not need to be aligned (i.e. remove the extra space before the =.

Thanks @GaryJ. Added another patch. Do we have an option to delete an uploaded patch?

#3 @GaryJ
4 years ago

Not without special capabilities on Trac, but that's fine - it's good to see the progression of patches, and the committers know that the most recent patches are likely the one to commit.

#4 @GaryJ
4 years ago

  • Component changed from Formatting to Shortcodes
  • Keywords has-patch added
  • Summary changed from Fix code indent to Fix code indent in unescape_invalid_shortcodes()

#5 @netweb
4 years ago

  • Keywords commit added
  • Milestone changed from Awaiting Review to 5.0
  • Version changed from 4.9.4 to 4.3

Introduced in [33359]

Thanks @joelcj91 & @GaryJ

#6 @SergeyBiryukov
4 years ago

  • Owner set to SergeyBiryukov
  • Resolution set to fixed
  • Status changed from new to closed

In 42738:

Coding Standards: Fix code indent in unescape_invalid_shortcodes().

Props joelcj91, GaryJ.
Fixes #43346.

#7 @johnbillion
3 years ago

  • Milestone changed from 5.0 to 5.1

#8 @boonebgorges
2 years ago

In 46188:

Query: Expand the list of operators available to compare_key in WP_Meta_Query.

compare_key, introduced in #42409, previously supported only = and LIKE
operators. This changeset introduces a number of other operators: !=, IN,
NOT IN, NOT LIKE, RLIKE, REGEXP, NOT REGEXP, EXISTS, and NOT EXISTS
(the latter two aliased to = and !=, respectively). To support case-sensitive
regular expression key comparisons, the new type_key parameter will force
a MySQL CAST when 'BINARY' is passed.

Props soulseekah.
Fixes #43346.

Note: See TracTickets for help on using tickets.