Make WordPress Core

Opened 4 years ago

Closed 4 years ago

Last modified 3 years ago

#43355 closed defect (bug) (fixed)

Improve inline docs for wp_dropdown_pages() - mention support for get_pages() arguments

Reported by: birgire Owned by: SergeyBiryukov
Milestone: 5.1 Priority: normal
Severity: normal Version:
Component: Posts, Post Types Keywords: has-patch
Focuses: docs Cc:


It's not clear from the documentation that wp_dropdown_pages() also supports get_pages() input arguments.

Here are two ways to fix that:

1) For comparison we have the following docblock line in wp_list_pages() src:

@see get_pages() 

2) We also have this docblock line in wp_page_menu() src:

*     Optional. Arguments to generate a page menu. See wp_list_pages() for additional arguments.

where we look at the wp_list_pages() reference for comparison.

Attachments (1)

43355.diff (710 bytes) - added by birgire 4 years ago.

Download all attachments as: .zip

Change History (5)

4 years ago

#1 @birgire
4 years ago

  • Keywords has-patch added

43355.diff adds a get_pages() references in the docblock of wp_dropdown_pages().

#2 @SergeyBiryukov
4 years ago

  • Milestone changed from Awaiting Review to 5.0

#3 @SergeyBiryukov
4 years ago

  • Owner set to SergeyBiryukov
  • Resolution set to fixed
  • Status changed from new to closed

In 42721:

Docs: Add a reference to get_pages() arguments in wp_dropdown_pages() and wp_list_pages(), as they both use the function internally.

Props birgire.
Fixes #43355.

#4 @johnbillion
3 years ago

  • Milestone changed from 5.0 to 5.1
Note: See TracTickets for help on using tickets.