WordPress.org

Make WordPress Core

Opened 3 years ago

Closed 3 years ago

Last modified 18 months ago

#43382 closed enhancement (fixed)

Terms list table: the Quick Edit link should be a button

Reported by: afercia Owned by: afercia
Milestone: 5.1 Priority: normal
Severity: normal Version:
Component: Administration Keywords: semantic-buttons has-patch
Focuses: ui, accessibility, javascript Cc:

Description

As done for the Posts list in #38677, the Quick Edit link should be a button. Currently, it uses a JS-generated role="button" attribute, but marking it up directly as button is preferable.

Also, it would benefit from an aria-expanded attribute to communicate to assistive technologies the expanded / collapsed status of the Quick Edit form. This would bring it in parity with what has been done for the Posts list Quick Edit in #38677 / [42725].

Attachments (1)

43382.diff (2.2 KB) - added by afercia 3 years ago.

Download all attachments as: .zip

Change History (6)

@afercia
3 years ago

#1 @afercia
3 years ago

  • Keywords has-patch added

43382.diff proposes the same changes already introduced for the Posts Quick Edit link in in #38677 / [42725].

#2 @afercia
3 years ago

  • Owner set to afercia
  • Resolution set to fixed
  • Status changed from new to closed

In 42727:

Accessibility: Change the terms "Quick Edit" link to a button.

For better accessibility and semantics, user interface controls that perform an
action should be buttons. Links should exclusively be used for navigation.
See #38677 / [42725].

Fixes #43382.

#3 @afercia
3 years ago

In 42767:

Accessibility: Change the comments "Quick Edit" and "Reply" links to buttons.

For better accessibility and semantics, user interface controls that perform an
action should be buttons. Links should exclusively be used for navigation.

Props Cheffeid, audrasjb, afercia.
See #43382, #38677.
Fixes #43376.

#4 @pento
2 years ago

  • Milestone changed from 5.0 to 5.1

#5 @atimmer
18 months ago

In 45553:

Comments: Open comment quick edit on double click.

In [42767] the quick edit button changed from a link to a button. This caused the jQuery code that selects on a link to no longer work. This commit restores the previous behavior.

Fixes #47572.
See #43382, #38677.

Note: See TracTickets for help on using tickets.