WordPress.org

Make WordPress Core

Opened 4 months ago

Last modified 4 days ago

#43405 assigned defect (bug)

CS: Fix violations for wp-signup.php

Reported by: GaryJ Owned by: jrf
Milestone: 5.0 Priority: normal
Severity: normal Version: trunk
Component: Users Keywords: has-patch commit
Focuses: multisite, coding-standards Cc:

Description

Address code standard violations in wp-signup.php.

Attachments (3)

wp-signup.diff (9.2 KB) - added by GaryJ 4 months ago.
43405.diff (9.2 KB) - added by nikolam 10 days ago.
Applied feedback from @jrf
43405.2.diff (8.1 KB) - added by netweb 9 days ago.

Download all attachments as: .zip

Change History (9)

@GaryJ
4 months ago

#1 @GaryJ
4 months ago

  • Keywords has-patch added

#2 @jrf
4 months ago

  • Version set to trunk

+1

Couple of small remarks/questions (line nrs refer to the "new" lines):

  • Line 122: ( $site_domain ) does not need the parentheses anymore as it is, though it might need output escaping.
  • Line 406/412 - the "Don't override WP globals" sniff is more than anything intended for plugins/themes. Should that sniff be excluded for core ?
  • Line 933: you may want to split this line up as it's pretty long now, i.e. one condition per line.

#3 @netweb
4 months ago

  • Milestone changed from Awaiting Review to 5.0

#4 @SergeyBiryukov
4 months ago

  • Component changed from General to Users
  • Focuses multisite added

@nikolam
10 days ago

Applied feedback from @jrf

@netweb
9 days ago

#5 @netweb
9 days ago

  • Keywords commit added

Patch 43405.2.diff updates 43405.diff and wp-signup.diff with a couple of whitespace indentation issues and removes the instance of phpcs:ignore as it is not required.

#6 @netweb
4 days ago

  • Owner set to jrf
  • Status changed from new to assigned
Note: See TracTickets for help on using tickets.