CS: Fix violations for wp-signup.php

[GaryJ]

Address code standard violations in wp-signup.php.

[jrf]

+1

Couple of small remarks/questions (line nrs refer to the "new" lines):

• Line 122: ( $site_domain ) does not need the parentheses anymore as it is, though it might need output escaping.
• Line 406/412 - the "Don't override WP globals" sniff is more than anything intended for plugins/themes. Should that sniff be excluded for core ?
• Line 933: you may want to split this line up as it's pretty long now, i.e. one condition per line.

[nikolam]

Applied feedback from @jrf

[netweb]

Patch 43405.2.diff​ updates 43405.diff​ and wp-signup.diff​ with a couple of whitespace indentation issues and removes the instance of phpcs:ignore as it is not required.

[desrosj]

43405.3.diff​ is a refresh to apply cleanly to trunk. Can someone just give it a review?

[jrf]

@desrosj I've given it a once-over. LGTM, just two remarks:

1. The condition on line 925/939 is still hard to read and confusing for people who don't know operator precedence well enough by heart.

Suggested alternative:

<?php
if ( 'all' === $active_signup
    || ( 'blog' === $_POST['signup_for'] && 'blog' === $active_signup )
    || ( 'user' === $_POST['signup_for'] && 'user' === $active_signup )
) {
    // Code
}

2. FYI/For future reference: it's likely that we'll be moving away from Yoda conditions in the near future, see ​https://github.com/WordPress-Coding-Standards/WordPress-Coding-Standards/issues/1624, but as that hasn't been actioned yet, that shouldn't influence this patch.

[desrosj]

Thanks, @jrf! 43405.4.diff​ includes your suggestion above.

[desrosj]

In 44626:

Coding Standards: Manually fix coding standards violations in wp-signup.php.

Props GaryJ, jrf, netweb, desrosj.
Fixes #43405.

[desrosj]

In 44628:

Privacy: Allow column sorting in the privacy request admin tables.

This allows users to sort the export and erase personal data request tables by “Requester” (post_title, or user email) and “Requested” (post_date, or when the request was created), which can be helpful when sites have many requests present.

Props birgire, ianbelanger, pbiron, desrosj.
Fixes #43405.

[desrosj]

Sorry for the noise. [44628] does not belong to this ticket.