Make WordPress Core

Opened 6 years ago

Closed 21 months ago

#43406 closed defect (bug) (fixed)

CS: Fix violations for wp-trackback.php

Reported by: garyj's profile GaryJ Owned by:
Milestone: 6.1 Priority: normal
Severity: normal Version:
Component: Pings/Trackbacks Keywords: has-patch 2nd-opinion
Focuses: coding-standards Cc:


Address code standard violations for wp-trackback.php.

Attachments (1)

wp-trackback.diff (1.0 KB) - added by GaryJ 6 years ago.

Download all attachments as: .zip

Change History (10)

6 years ago

#1 @GaryJ
6 years ago

  • Focuses coding-standards added
  • Keywords has-patch added

This ticket was mentioned in Slack in #core-coding-standards by garyj. View the logs.

6 years ago

#3 @jrf
6 years ago

  • Version set to trunk


Just a small question - why not have the first whitelist on the line above the variable declaration as well ?

Oh and maybe add -- renaming WP global would be BC break or something, so it's documented why the variable name is exempt.

#4 @netweb
6 years ago

  • Milestone changed from Awaiting Review to 5.0

#5 @SergeyBiryukov
6 years ago

  • Component changed from General to Pings/Trackbacks

#6 @johnbillion
6 years ago

  • Milestone changed from 5.0 to 5.1

#7 @pento
5 years ago

  • Keywords 2nd-opinion added
  • Milestone changed from 5.1 to Future Release
  • Version trunk deleted

We actually could rename $comment_post_ID, I suspect without breaking back compat.

See #23231 for an example of how it's been done in the past. This is a bit of a bigger thing that just adding a phpcs:ignore comment, though. 🙂

#8 follow-up: @sabernhardt
21 months ago

Is this fixed by changeset:53719?

#9 in reply to: ↑ 8 @SergeyBiryukov
21 months ago

  • Milestone changed from Future Release to 6.1
  • Resolution set to fixed
  • Status changed from new to closed

Replying to sabernhardt:

Is this fixed by changeset:53719?

Yes, thanks! I forgot to search for an existing ticket before the commit :)

Note: See TracTickets for help on using tickets.