Opened 7 years ago
Closed 2 years ago
#43406 closed defect (bug) (fixed)
CS: Fix violations for wp-trackback.php
| Reported by: |
|
Owned by: | |
|---|---|---|---|
| Milestone: | 6.1 | Priority: | normal |
| Severity: | normal | Version: | |
| Component: | Pings/Trackbacks | Keywords: | has-patch 2nd-opinion |
| Focuses: | coding-standards | Cc: |
Description
Address code standard violations for wp-trackback.php.
Attachments (1)
Change History (10)
This ticket was mentioned in Slack in #core-coding-standards by garyj. View the logs.
7 years ago
#7
@
6 years ago
- Keywords 2nd-opinion added
- Milestone changed from 5.1 to Future Release
- Version trunk deleted
We actually could rename $comment_post_ID, I suspect without breaking back compat.
See #23231 for an example of how it's been done in the past. This is a bit of a bigger thing that just adding a phpcs:ignore comment, though. 🙂
#8
follow-up:
↓ 9
@
2 years ago
Is this fixed by changeset:53719?
#9
in reply to:
↑ 8
@
2 years ago
- Milestone changed from Future Release to 6.1
- Resolution set to fixed
- Status changed from new to closed
Replying to sabernhardt:
Is this fixed by changeset:53719?
Yes, thanks! I forgot to search for an existing ticket before the commit :)
Note: See
TracTickets for help on using
tickets.
+1
Just a small question - why not have the first whitelist on the line above the variable declaration as well ?
Oh and maybe add
-- renaming WP global would be BC breakor something, so it's documented why the variable name is exempt.