Make WordPress Core

Opened 4 years ago

Closed 3 years ago

#43407 closed enhancement (fixed)

Make site_url filter aware of wp-login.php actions

Reported by: jfarthing84 Owned by: SergeyBiryukov
Milestone: 5.3 Priority: normal
Severity: normal Version:
Component: Login and Registration Keywords: has-patch dev-feedback
Focuses: Cc:


For instance, wp_registration_url() passes the action to site_url():

$registration_url = site_url( 'wp-login.php?action=register' );

However, wp_logout_url() and wp_lostpassword_url() do not. Attaching a patch to fix this.

Attachments (1)

43407.patch (1.2 KB) - added by jfarthing84 4 years ago.

Download all attachments as: .zip

Change History (12)

4 years ago

#1 @johnbillion
4 years ago

  • Keywords has-patch added
  • Milestone changed from Awaiting Review to 5.0
  • Owner set to johnbillion
  • Status changed from new to reviewing
  • Version trunk deleted

#2 @johnbillion
3 years ago

  • Milestone changed from 5.0 to 5.0.1

#3 @pento
3 years ago

  • Milestone changed from 5.0.1 to 5.0.2

#4 @pento
3 years ago

  • Milestone changed from 5.0.2 to 5.0.3

#5 @audrasjb
3 years ago

  • Keywords dev-feedback added


5.0.3 is going to be released at the beginning of January. We are currently sorting the remaining tickets in the milestone. Do you think this ticket can be handled/reviewed in the next few days? If not, let's address this in 5.1 which is coming soon.

Adding dev-feedback keywords to see if it can land in 5.0.3.

This ticket was mentioned in Slack in #core by desrosj. View the logs.

3 years ago

#7 @desrosj
3 years ago

  • Milestone changed from 5.0.3 to 5.1

Going to punt this to 5.1. It is outside of the scope for 5.0.3 (block
editor bugs, regressions, and major bugs).

#8 @SergeyBiryukov
3 years ago

  • Owner changed from johnbillion to SergeyBiryukov

#9 @pento
3 years ago

  • Milestone changed from 5.1 to 5.2

#10 @desrosj
3 years ago

  • Milestone changed from 5.2 to 5.3

This ticket has not received any attention during the 5.2 cycle. With beta 1 tomorrow, going to punt this to 5.3.

#11 @SergeyBiryukov
3 years ago

  • Resolution set to fixed
  • Status changed from reviewing to closed

In 45398:

Login and Registration: Pass the action to site_url() in wp_logout_url() and wp_lostpassword_url():

  • Make site_url filter in wp_logout_url() aware of the logout action.
  • Make network_site_url filter in wp_lostpassword_url() aware of the lostpassword action.

Props jfarthing84.
Fixes #43407.

Note: See TracTickets for help on using tickets.