WordPress.org
Get WordPress

Make WordPress Core

Opened 8 years ago

Closed 8 years ago

Last modified 8 years ago

#43411 closed defect (bug) (fixed)

Remove `vendor` file name entry from `.gitignore`

Reported by: netweb Owned by: SergeyBiryukov
Priority: normal Milestone: 5.0
Component: Build/Test Tools Version:
Severity: normal Keywords: has-patch commit fixed-5.0
Cc: Focuses:

Description (last modified by netweb)

It looks like vendor snuck into the .gitignore via [41681] and again in [43309] and should be removed.

As it is vendor and not /vendor it refers to a filename per ​https://git-scm.com/docs/gitignore#_pattern_format

The vendor/ path (in reference to Composer) was added later in [42405] and should remain as is.

Attachments (2)

43411.diff​ (199 bytes ) - added by netweb 8 years ago.
43411-50branch.diff​ (199 bytes ) - added by netweb 8 years ago.

Download all attachments as: .zip

Change History (13)

@netweb
8 years ago

#1 @netweb
8 years ago

  • Keywords has-patch commit added
  • Milestone Awaiting Review → 5.0

#2 @SergeyBiryukov
8 years ago

  • Owner set to SergeyBiryukov
  • Resolution → fixed
  • Status new → closed

In 42733:

Build/Test Tools: Remove vendor file name entry from .gitignore.

Props netweb.
Fixes #43411.

#3 @jorbin
8 years ago

  • Milestone 5.0 → 5.1

#4 @netweb
8 years ago

  • Description modified (diff)

#5 @netweb
8 years ago

  • Milestone 5.1 → 5.0
  • Resolution fixed
  • Status closed → reopened

As part of adding PHPCS to the 5.0 branch reopening and moving back to the 5.0 milestone

@netweb
8 years ago

#6 @netweb
8 years ago

Patch 43411-50branch.diff​ for the 5.0 branch is ready for commit

#7 @netweb
8 years ago

Patch 43411-50branch.diff​ is based on [42733] for backporting to the 5.0 branch

#8 @SergeyBiryukov
8 years ago

  • Resolution → fixed
  • Status reopened → closed

In 43747:

Build/Test Tools: Remove vendor file name entry from .gitignore.

Props netweb.
Merges [42733] to the 5.0 branch.
Fixes #43411.

#9 @netweb
8 years ago

  • Keywords fixed-5.0 added
  • Resolution fixed
  • Status closed → reopened

The /trunk commit [43309] reverted the original [42733] commit in this ticket, reopening for that in /trunk later

#10 @SergeyBiryukov
8 years ago

  • Resolution → fixed
  • Status reopened → closed

In 44285:

Build/Test Tools: Remove vendor file name entry from .gitignore.

Props netweb.
Merges [43747] to trunk.
Fixes #43411.

This ticket was mentioned in ​Slack in #core-committers by flixos90. ​View the logs.
8 years ago

Note: See TracTickets for help on using tickets.