Opened 7 years ago
Closed 6 years ago
#43415 closed defect (bug) (fixed)
Remove "aria-required" attribute when "required" attribute is already used
Reported by: | audrasjb | Owned by: | SergeyBiryukov |
---|---|---|---|
Milestone: | 5.1 | Priority: | normal |
Severity: | normal | Version: | 4.9.4 |
Component: | Media | Keywords: | good-first-bug has-patch |
Focuses: | accessibility | Cc: |
Description
Quote from Andrea in #39045 :
There was a time when both were needed. Today, it's safe to use just required. Instead, aria-required is for custom, non-native, controls. Also, just stumbled upon a good feedback from Adrian Roselli: https://stackoverflow.com/a/37975985
I found both aria-required
and required
attributes used in the following file:
wp-admin/includes/media.php
L. 1672, 1674, 1849, 2756, 2763 and note also that it should userequired
instead ofaria-required
at L. 2772.
Related: #39045
Attachments (1)
Change History (13)
#1
@
7 years ago
- Focuses accessibility added
- Keywords good-first-bug added
- Milestone changed from Awaiting Review to Future Release
#4
@
7 years ago
- Keywords needs-refresh added
@Shital Patel thanks for the patch. A good best practice for patches is to try to not introduce unrelated changes, see onclick and readonly in 43415.patch better to not change them. Also, required
is a boolean attribute that means it doesn't need to have a specified value required="required"
and the correct syntax is just required
.
#5
@
7 years ago
- Component changed from General to Media
- Milestone changed from Future Release to 5.0
#6
@
7 years ago
- Owner set to SergeyBiryukov
- Resolution set to fixed
- Status changed from new to closed
In 42759:
I added patch for media.php