![(please configure the [header_logo] section in trac.ini)](/chrome/site/your_project_logo.png){kind=logo}
Opened 8 years ago
Closed 8 years ago
#43415 closed defect (bug) (fixed)
Remove "aria-required" attribute when "required" attribute is already used
| Reported by: | audrasjb | Owned by: | SergeyBiryukov |
|---|---|---|---|
| Priority: | normal | Milestone: | 5.1 |
| Component: | Media | Version: | 4.9.4 |
| Severity: | normal | Keywords: | good-first-bug has-patch |
| Cc: | Focuses: | accessibility |
Description
Quote from Andrea in #39045 :
There was a time when both were needed. Today, it's safe to use just required. Instead, aria-required is for custom, non-native, controls. Also, just stumbled upon a good feedback from Adrian Roselli: https://stackoverflow.com/a/37975985
I found both aria-required and required attributes used in the following file:
wp-admin/includes/media.phpL. 1672, 1674, 1849, 2756, 2763 and note also that it should userequiredinstead ofaria-requiredat L. 2772.
Related: #39045
Attachments (1)
Change History (13)
#1
@
8 years ago
- Focuses accessibility added
- Keywords good-first-bug added
- Milestone Awaiting Review → Future Release
#4
@
8 years ago
- Keywords needs-refresh added
@Shital Patel thanks for the patch. A good best practice for patches is to try to not introduce unrelated changes, see onclick and readonly in 43415.patch better to not change them. Also, required is a boolean attribute that means it doesn't need to have a specified value required="required" and the correct syntax is just required.
I added patch for media.php