Context Navigation

← Previous Ticket
Next Ticket →

#43417 closed defect (bug) (fixed)

Infinite loop in wp_mkdir_p with open_basedir restrictions

Reported by:	1265578519	Owned by:	SergeyBiryukov
Priority:	normal	Milestone:	4.9.5
Component:	Filesystem API	Version:	3.7
Severity:	normal	Keywords:	has-patch fixed-major
Cc:		Focuses:

Description

Cause the head exceeds the 4M limit.

/wwwroot/wp-includes/functions.php 1618

modify is_dir front @ cpu 100%.

Attachments (1)

43417.diff (626 bytes ) - added by soulseekah 8 years ago.: Initial fix attempt

Download all attachments as: .zip

Change History (11)

#1 @soulseekah
8 years ago

Component Canonical → Filesystem API
Summary upstream protocol header size is too big → Infinite loop in wp_mkdir_p with open_basedir restrictions

It's an infinite loop :D to reproduce:

<?php
ini_set( 'open_basedir', '/tmp/' );
wp_mkdir_p( '/hello/world/' );

Last edited 8 years ago by soulseekah (previous) (diff)

@soulseekah
8 years ago

Attachment 43417.diff added

Initial fix attempt

#2 @soulseekah
8 years ago

Keywords has-patch needs-unit-tests added

The test is tough to write, once ini_set is called the whole test suite breaks. Plus the test can't fail, because it's in an infinite loop, it can only pass.

<?php
        /**
         * @ticket 43417
         */
        public function test_wp_mkdir_p_loop() {
                ini_set( 'open_basedir', '/no/exists/ever' );

                // suppress open_basedir restriction errors
                @wp_mkdir_p( '/tmp/try/his' );

                ini_restore( 'open_basedir' );
        }

#3 @1265578519
8 years ago

Thanks, 43417.diff successfully solved the problem .

#4 @SergeyBiryukov
8 years ago

Milestone Awaiting Review → 5.0

#5 @soulseekah
8 years ago

Didn't think I'd ever encounter this, but I just saw this happen on a migrated client site via a call to wp_upload_dir from Divi theme, where the et_images_temp_folder option was not replaced correctly.

An incorrect/badly formed upload_path would also get into an infinite loop. So this is not a theoretical scenario, this actually happens :(

Patch got rid of infinite loop in wp_mkdir_p call.

Any ideas on how to automate test for this? Or can this be merged without unit tests due to it being so dangerous to test?

#6 @SergeyBiryukov
8 years ago

Version trunk → 3.7

Introduced in [25047].

#7 @SergeyBiryukov
8 years ago

Owner set to SergeyBiryukov
Resolution → fixed
Status new → closed

In 42801:

Filesystem API: Avoid an infinite loop in wp_mkdir_p() when trying to determine the parent folder with open_basedir restriction in effect.

Props soulseekah, 1265578519-1.
Fixes #43417.

#8 @SergeyBiryukov
8 years ago

Keywords fixed-major added; needs-unit-tests removed
Milestone 5.0 → 4.9.5
Resolution fixed
Status closed → reopened

Reopening for 4.9.5 consideration.

#9 @SergeyBiryukov
8 years ago

Resolution → fixed
Status reopened → closed

In 42804:

Filesystem API: Avoid an infinite loop in wp_mkdir_p() when trying to determine the parent folder with open_basedir restriction in effect.

Props soulseekah, 1265578519-1.
Merges [42801] to the 4.9 branch.
Fixes #43417.

#10 @costdev
3 years ago

#36184 was marked as a duplicate.

Note: See TracTickets for help on using tickets.

Download in other formats:

Make WordPress Core

Context Navigation

#43417 closed defect (bug) (fixed)

Infinite loop in wp_mkdir_p with open_basedir restrictions

Description

Attachments (1)

Change History (11)

#1 @soulseekah 8 years ago

@soulseekah 8 years ago

#2 @soulseekah 8 years ago

#3 @1265578519 8 years ago

#4 @SergeyBiryukov 8 years ago

#5 @soulseekah 8 years ago

#6 @SergeyBiryukov 8 years ago

#7 @SergeyBiryukov 8 years ago

#8 @SergeyBiryukov 8 years ago

#9 @SergeyBiryukov 8 years ago

#10 @costdev 3 years ago