WordPress.org

Make WordPress Core

Opened 3 years ago

Closed 9 months ago

Last modified 9 months ago

#43429 closed enhancement (fixed)

Add "In response to ..." before threaded comments in comment feed

Reported by: zodiac1978 Owned by: SergeyBiryukov
Milestone: 5.4 Priority: normal
Severity: normal Version:
Component: Comments Keywords: ux-feedback has-patch commit
Focuses: Cc:

Description

Imagine this in your feed reader:

Comment 1: WordCamp Miami was awesome!
Comment 2: I do not learn anything. It was boring ... :(
Comment 3: YES, it was!

But Comment 3 is a reply to Comment 1. But we don't see it.

I am thinking about making it to something like that:

Comment 1: WordCamp Miami was awesome!
Comment 2: I do not learn anything. It was boring ... :(
Comment 3: (In response to *Comment 1*.) YES, it was!

There already some places in WordPress which are doing that:

https://github.com/WordPress/WordPress/blob/aaf99e691391cfceb004d848450dbbf3344b1bee/wp-admin/comment.php#L194

https://github.com/WordPress/WordPress/blob/aaf99e691391cfceb004d848450dbbf3344b1bee/wp-admin/edit-form-comment.php#L133

Attachments (2)

43429.diff (1.5 KB) - added by SergeyBiryukov 16 months ago.
43429.2.diff (1.7 KB) - added by imath 9 months ago.

Download all attachments as: .zip

Change History (16)

#1 @zodiac1978
3 years ago

  • Keywords needs-patch added
  • Severity changed from normal to minor

#3 @melchoyce
3 years ago

  • Keywords ux-feedback added

This ticket was mentioned in Slack in #design by karmatosed. View the logs.


21 months ago

#6 @zodiac1978
20 months ago

  • Severity changed from minor to normal

Read the Slack "discussion" and wanted to give more feedback, but I don't know what is meant by this feedback from @karmatosed :

What do people think?

Is it a question about the user and therefore a rhetorical UX question? Or is it something directed to me? Do you think this is an absurd edge case which should be ignored?

mukesh27 wrote:

It can be achieved using plugin as per user said

Yes, this plugin is from me, but if WP is interested this could be merged to core. If not, please close as Wontfix. If yes, I can provide a patch for it based on the plugin.

joyously asked:

It's a feed, isn't there a format already for it? Does it depend on what you use to view the feed? Would it change what the feed reader software is expecting?

I don't know any feedreader which can show threaded comments. All feedreader show the feed in plain chronological (or reverses chronological) order. No threading. And therefore this addition would make sense IMHO. The RSS spec has no threading at all if I am right.

#7 @karmatosed
20 months ago

@zodiac1978 sorry that was confusing for you to read out of context, let me clarify. Every week the design team runs a triage session. This came up during it. I was offering up the issue for discussion to the group attending. I wasn't bringing any judgement as it was something everyone was able to give insight on.

#8 @zodiac1978
20 months ago

  • Keywords dev-feedback added

Thanks for the clarification @karmatosed - I thought it was rude, because for me it looks like you were questioning the significance of the ticket. Fortunately this wasn't the case.

I am still interested if this could be something for core. Does anyone have feedback for me about the mentioned plugin solution?

#9 @SergeyBiryukov
16 months ago

  • Keywords has-patch added; needs-patch dev-feedback removed
  • Milestone changed from Awaiting Review to 5.3
  • Owner set to SergeyBiryukov
  • Status changed from new to accepted

Adding In reply to %s to child comments in comments feed seems like a quick win.

Let's do this, along with #43805.

#10 @davidbaumwald
13 months ago

  • Milestone changed from 5.3 to Future Release

With version 5.3 Beta 1 releasing shortly, the deadline for enhancements is now passed. This is being moved to Future Release.

#11 @SergeyBiryukov
11 months ago

  • Milestone changed from Future Release to 5.4

@imath
9 months ago

#12 @imath
9 months ago

  • Keywords commit added

Hi @SergeyBiryukov

Thanks a lot for your work on the patch. I've just added a .2.diff one to edit the docblock part changing 5.3.0 for 5.4.0. I've also tested the patch and I confirm it behaves as expected. I believe, just like #43805 it's ready to be committed.

#13 @SergeyBiryukov
9 months ago

  • Resolution set to fixed
  • Status changed from accepted to closed

In 47111:

Comments: Add In reply to %s. prefix to child comments in comments feed.

The prefix includes a link to the parent comment and the name of its author.

Props zodiac1978, imath, SergeyBiryukov.
Fixes #43429.

#14 @SergeyBiryukov
9 months ago

In 47114:

Comments: Add In reply to: %s parent comment link to new comment email notifications.

This information was previously available on the Moderate Comment screen in the admin, but was missing from moderation emails.

Props imath, danieltj, andraganescu, galbaras, SergeyBiryukov.
Fixes #43805. See #43429.

Note: See TracTickets for help on using tickets.