Changes between Initial Version and Version 1 of Ticket #43438, comment 79
- Timestamp:
- 08/24/2018 08:49:02 PM (7 years ago)
Legend:
- Unmodified
- Added
- Removed
- Modified
-
Ticket #43438, comment 79
initial v1 4 4 > I made that code consolidation change in [attachment:"43438.17.diff"]. I also fixed the `@group ajax1` typo and fixed some typos in the erasure tests that incorrectly referred to exporting. 5 5 6 We've both {{{_unset_ exporter_key()}}} and {{{_erase_eraser_key()}}}. I would suggest e.g. using former in both test classes.6 We've both {{{_unset_..._key()}}} and {{{_erase_..._key()}}}. Should we use same naming format in both test classes? 7 7 8 8 Should we use protected/private for the underscore helper methods, that don't need public visibility?