Make WordPress Core

Opened 6 years ago

Last modified 4 years ago

#43444 new defect (bug)

CSS Editor Error Not Displaying Correctly

Reported by: nistuj817's profile nistuj817 Owned by:
Milestone: Future Release Priority: normal
Severity: normal Version: 4.9
Component: Customize Keywords: reporter-feedback
Focuses: ui, javascript Cc:


Every time I’m making a change in the custom CSS I get this annoying message that should only appear when I’m ready to publish changes. When I click publish and there’s errors, that’s when this notification needs to appear. I get it when I’m in the process of editing CSS and it always throws off my position when and I lose the location of where I was editing. It’s even worse when Inspect Element is pulled up.

It should ONLY be giving me an error message when I’m going to publish the CSS changes. It’s literally notifying me of errors when I’m not finished editing the CSS. When I click “Publish” it needs to be notifying me of errors and then to confirm, not make me lose my placement and give me an error when I’m not even finished writing out what I need to…

Screen capture:

Change History (4)

#1 @nistuj817
6 years ago

  • Severity changed from normal to major

I totally understand the point of the message, but that’s exactly why the red X’s show to the left of the line. Those are helpful, but when you’re not a “perfect developer writing error-free code”, often times you try things out…and also begin writing a line and locate similar CSS elsewhere, usually within the same CSS editor to reference a certain setup or class. Again the error icons with the red next to the lines are great, it’s the fact the “before you can save. Update anyway?” message appears when I don’t even click publish. That message needs to only appear when there’s broken CSS and I click publish. Does that make sense? It’s really annoying to appear everytime I’m nowhere near ready to publish and save changes.

#2 @afercia
6 years ago

#43562 was marked as a duplicate.

#3 @afercia
6 years ago

  • Component changed from General to Customize
  • Focuses ui javascript added
  • Severity changed from major to normal
  • Version changed from 4.9.4 to 4.9

#4 @dlh
4 years ago

  • Keywords reporter-feedback added
  • Milestone changed from Awaiting Review to Future Release

@nistuj817, are you able to revive the screen capture? The YouTube link is dead.

I can understand how having that notice appear and disappear as you type could get annoying. It seems to me that the notice could serve a purpose even before the user is ready to publish, though: If there is a linting error preventing the expected CSS changes from appearing in the preview, the notice can help a newer user relate the error icons in the editor gutter to what they see (or don't see) in the preview in a way that the icons alone might not. What do you think? Any ideas for how a balance might be struck?

Note: See TracTickets for help on using tickets.