Make WordPress Core

Opened 13 years ago

Closed 13 years ago

#4345 closed enhancement (fixed)

On the Comment Editing screens, need a link to View Post that the comment is on

Reported by: dgold Owned by: westi
Milestone: 2.5 Priority: normal
Severity: normal Version:
Component: Administration Keywords: has-patch
Focuses: Cc:


In the Admin > Comments screens, when editing comments, I would like a Link to View The Post that the Comment is on.

For example -- I'm looking at a Comment, trying to Edit it, and it's not clear what the person was responding to. Where's my post, that has this comment on it? I don't see anything telling me what the original post was. Can you add "View Post" here?

The example screen I'm looking at is:

Attachments (2)

edit-form-comment.php.diff (1.2 KB) - added by mgrouchy 13 years ago.
Correct Patch for edit-form-comment.php(new)
wp-admin.css.diff (349 bytes) - added by mgrouchy 13 years ago.
Correct Patch for wp-admin.css(new)

Download all attachments as: .zip

Change History (17)

#1 @rob1n
13 years ago

  • Owner changed from anonymous to rob1n

There's a link (the post title) on wp-admin/edit-comments.php with the link (before you edit a comment), if that helps.

But I agree.

#2 @rob1n
13 years ago

  • Milestone changed from 2.4 to 2.3

#3 @mgrouchy
13 years ago

  • Owner changed from rob1n to mgrouchy

Hey Guys, I'm a summer of code student with WordPress and what I'm working on are enhancements to the Comment panel for Wordpress. I have fixed the issue in this ticket but I forgot to check my patches against the trunk code. If someone can delete the above patches(I don't think I can?) I am gonna upload the correct ones now in a second.

#4 @mgrouchy
13 years ago

  • Resolution set to fixed
  • Status changed from new to closed

Okay, Correct Patches added. I have tested it, seems to work fine. I'm calling this fixed. If more any more additions need to be added, let me know.


#5 @foolswisdom
13 years ago

  • Keywords has-patch added
  • Resolution fixed deleted
  • Status changed from closed to reopened

mgrouchy: it is marked Fixed by a commiter if they check in your patch (after reviewing it)

#6 @rob1n
13 years ago

  • Owner changed from mgrouchy to rob1n
  • Status changed from reopened to new

#7 @mgrouchy
13 years ago

Sorry, did not know :) First time posting to Trac! Knew I was going to make more than 1 mistake on here.

#8 @rob1n
13 years ago

A few items of concern -- don't take this as personal criticism or anything, just what I would change:

  1. Bad placement -- above there is not the best place to put it, IMO. I would put it at the other side of the submit button.
  2. We try to use semantic HTML in the admin (and everywhere else, really), and <br /><br /> is very presentational.
  3. Don't run dynamic things through the gettext functions. Realistically speaking, the post title is already in the user's language, so that would be useless. The &raquo; would need some treatment, however, so I would use sprintf('%s &raquo;', post_title), or something similar.

#9 @mgrouchy
13 years ago

I don't take it personal at all.

1.) The Reason why I put it up there is because that is similar placement to where it is in edit post/edit page. I only moved it to the top, because when I matched it to exact placement with edit page/post it looked weird when you had really long post names. However, it could easily be pushed to the other side of the submit button if thats what the consensus is.

2) I knew the breaks were a bit hacky, once again, they were added because of the problem mentioned above with the really long post names, because the text buts against the text field. However, I can fix that with a tiny bit of css(and I will).

3) Once again, good to know. Will fix that as well.

Anyway, I need to run out now, If i can I will update the patches to reflect changes tonight.If not I will update them Tomorrow.

#10 @mgrouchy
13 years ago

Okay, so I took your advice. The line breaks are removed, the link is now lined up with the submit button on the bottom, and I switched the gettext to the formatted string (sprintf).

New diffs are there to replace the old.

Thanks for the input!

13 years ago

Correct Patch for edit-form-comment.php(new)

13 years ago

Correct Patch for wp-admin.css(new)

#11 @rob1n
13 years ago

  • Status changed from new to assigned

#12 @ryan
13 years ago

  • Milestone changed from 2.3 to 2.4

#13 @rob1n
13 years ago

  • Owner rob1n deleted
  • Status changed from assigned to new

#14 @westi
13 years ago

  • Owner set to westi
  • Status changed from new to assigned

#15 @westi
13 years ago

  • Resolution set to fixed
  • Status changed from assigned to closed

(In [6432]) Add a link to the post a comment is for when editing a comment. Fixes #4345 props mgrouchy,

Note: See TracTickets for help on using tickets.