WordPress.org

Make WordPress Core

Opened 4 months ago

Closed 3 months ago

Last modified 5 weeks ago

#43454 closed feature request (maybelater)

Add UI elements to make the user aware of image geo data

Reported by: desrosj Owned by:
Milestone: Priority: normal
Severity: normal Version:
Component: Privacy Keywords: ui-feedback has-screenshots has-patch gdpr
Focuses: Cc:

Description

During the most recent media component chat (https://wordpress.slack.com/archives/C02SX62S6/p1519932698000742), #9257 was discussed. The question of whether the user should be informed that location data is present in the image file came up.

#9257 will process that data and store it in meta, but will not expose that data unless a plugin or theme uses it for something. In WordPress' current state, the original file is not stripped of any geolocation data and anyone could potentially find that information.

Some concern was expressed about the potential for a user to unknowingly expose location data when activating a plugin or theme that utilizes it. Some ideas that were passed around to better inform the user about images containing GPS data:

  • Showing a warning when an image is uploaded that contains GPS data.
  • Showing a general notice
  • Showing a globe icon in the corner of the image thumbnail in the media library.
  • Showing the coordinates in the attachment info pane when editing an attachment (maybe with information about the data).
  • A general warning at the top of the upload screen.

Attachments (4)

Capture d’écran 2018-03-01 à 23.52.16.png (864.2 KB) - added by audrasjb 4 months ago.
First step: Displays GPS coordinates in attachement info panel
43454.1.diff (6.9 KB) - added by audrasjb 4 months ago.
Displays GPS coordinates in attachement info panel
43454.2.diff (8.6 KB) - added by audrasjb 4 months ago.
adds gps-location class and related css is the attachement is gps localized (first attempt for visual rendering)
Capture d’écran 2018-03-02 à 10.09.00.png (133.7 KB) - added by audrasjb 4 months ago.
adds gps-location class and related css is the attachement is gps localized (first attempt for visual rendering)

Download all attachments as: .zip

Change History (15)

#1 @desrosj
4 months ago

  • Summary changed from Add UI elements informing the user aware of image geo data. to Add UI elements to make the user aware of image geo data

#2 @audrasjb
4 months ago

  • Keywords has-screenshots has-patch added; needs-screenshots removed

Hello @desrosj

What a great ticket. By the way, I discovered the awesome work already made in #9257.

I virtually assumed the fonction added in the previous ticket exists in core and I made a patch for point 3: Showing the coordinates in the attachment info pane when editing an attachment.

The following patch is a first step which is merging ticket #9257 's last patch file with point 3 of the present ticket.

@audrasjb
4 months ago

First step: Displays GPS coordinates in attachement info panel

#3 @audrasjb
4 months ago

  • Keywords i18n-change added

@audrasjb
4 months ago

Displays GPS coordinates in attachement info panel

@audrasjb
4 months ago

adds gps-location class and related css is the attachement is gps localized (first attempt for visual rendering)

@audrasjb
4 months ago

adds gps-location class and related css is the attachement is gps localized (first attempt for visual rendering)

#4 @audrasjb
4 months ago

After 43454.1.diff first step, I jumped into the second step: 43454.2.diff introduce gps-location class and related CSS rule if the attachement is GPS localized as a very first attempt for visual rendering.

#5 @ocean90
4 months ago

  • Keywords i18n-change removed

i18n-change is only used during string freeze.

#6 @desrosj
4 months ago

@audrasjb thanks for tackling this! I would like to keep the actual processing of the EXIF data into metadata in #9257 and use this ticket to explore how/if the data should be exposed to users. There also may be some GDPR elements that we need to consider here.

I'd also love some other ideas for how to display this information, if at all.

#7 @audrasjb
4 months ago

@desrosj I guess I kept the actual processing of #9257, but I also added information rendering based on this process as requested. I know there is some GDPR elements to explore but all I wanted to do is a first technical basis to explore what can be done in /wp-admin with these geo-data :)

For me, the next steps are:

  • Discuss opportunity of displaying geo-data: in my opinion as soon as they are available in the files, they should be displayed in /wp-admin.
  • Add some informations about geo-data and GDPR in /uploads
  • Add an option to remove geo-data for media files should be a great enhancement :)

#8 @audrasjb
3 months ago

  • Milestone Awaiting Review deleted
  • Resolution set to maybelater
  • Status changed from new to closed

@desrosj unfortunately, let's close this ticket along with #9257 (GDPR Compliance). This is plugin territory now :)

#9 @allendav
2 months ago

  • Keywords gdpr added

Since location data is personal data, and it is possible to correlate authors with the attachments they upload in the REST API, we at least need to warn administrators to include a warning in their site's privacy policy about EXIF GPS data in media.

Even better though, we could warn users in the Media Library uploader that the image they uploaded contains EXIF GPS and the risks therein.

#10 @desrosj
2 months ago

@allendav We had decided to close this one alongside #9257 (which was deemed plugin territory for now). Without #9257, Core would be unaware of any EXIF GPS data.

Are you advocating for a general notice in the media library? Or one that is displayed when an image is uploaded that actually contains EXIF GPS data? If the latter, we should reopen both tickets. Regardless of whether Core is aware of the EXIF GPS data, any image that is uploaded does potentially have that data since the original uploaded media file is not modified on upload.

Just want to make sure we reopen the correct tickets for visibility!

#11 @desrosj
5 weeks ago

  • Component changed from Media to Privacy

Moving to the new Privacy component.

Note: See TracTickets for help on using tickets.