No placeholder for ico file in list view of Media Library

[Guido07111975]

Hi,

There's no placeholder image for an ico file in list view of the Media Library. But there is in grid view. Check attachment.

Guido

[Guido07111975]

No placeholder in list view

[SergeyBiryukov]

The list view is trying to display the icon, but with 1x1 dimensions for some reason.

[remyvv]

I have looked into this issue and figured out this is occurs due too a omission of IMAGETYPE_ICO in the $displayable_image_types inside the function file_is_displayable_image.
Because wp_generate_attachment_metadata calls this function to check if it should generate the metadata for an upload, the metadata is not generated for .ico files. And such wp_get_attachment_image outputs width and height as 1

The attached patch fixes this.

[remyvv]

Updated unit-tests as well.

[SergeyBiryukov]

Thanks for the patch, @remyvv! It works as expected.

The only thing I noted is that IMAGETYPE_ICO is only available in PHP 5.3+, while WordPress still supports 5.2.4+, so we'll have to check if it's defined.

It's also worth mentioning that metadata will only be generated for new icons, the ones previously uploaded will be left as is.

[SergeyBiryukov]

In 42780:

Media: Recognize .ico files as displayable images on PHP 5.3+ and allow attachment meta data to be generated for them.

Props remyvv, Guido07111975.
Fixes #43458.

[desrosj]

5.1 will be released shortly after 5.0.3, and as this is not within the 5.0.3 focuses (block editor bugs, regressions, and major bugs), it can wait.