Make WordPress Core

Opened 6 years ago

Last modified 6 years ago

#43476 new defect (bug)

Fix parentheses in post status links for RTL

Reported by: birgire's profile birgire Owned by:
Milestone: Awaiting Review Priority: normal
Severity: normal Version:
Component: Administration Keywords: has-screenshots 2nd-opinion
Focuses: rtl Cc:

Description

When switching to a RTL language, the parentheses in the post status links can become mixed up, when the status is not translated.

How to replicate the issue? Switch to e.g. the Azərbaycan dili language that is missing the Draft post status translation.

Where to see the issue?: Visit the wp-admin/edit.php and check out the parentheses in the Draft post status link.

Attachments (3)

su.JPG (12.1 KB) - added by birgire 6 years ago.
su-fix.jpg (12.1 KB) - added by birgire 6 years ago.
nav-menus-dropdown-with-user-input-including-parentheses.jpg (20.5 KB) - added by birgire 6 years ago.

Download all attachments as: .zip

Change History (6)

@birgire
6 years ago

@birgire
6 years ago

#1 @birgire
6 years ago

  • Keywords has-screenshots added

The screenshot in su.JPG shows the issue.

The screenshot in su-fix.jpg shows a possible fix, if the parentheses should be placed on the left side. Here I tested the unicode-bidi:

.subsubsub a .count {
    unicode-bidi: embed;
}

#2 @SergeyBiryukov
6 years ago

  • Keywords 2nd-opinion added

It can happen in any other place where parentheses are used with English words in an RTL locale.

Instead of patching these instances separately, I think it's better to encourage translation editors to finish the translation.

#3 @birgire
6 years ago

Here are examples of other parts using the .subsubsub a .count:

  • the comment status links in wp-admin/edit-comments.php.
  • the plugin status links wp-admin/plugins.php.

This can also happen in dropdowns.

@SergeyBiryukov yes, that might be the way to go, but I think we should at least take care of the parts that can contain user added options, like in /wp-admin/nav-menus.php. Maybe adjust this ticket or create a new one?

The screenshot in nav-menus-dropdown-with-user-input-including-parentheses.jpg shows what can happen when the user adds a menu containing parentheses.

Last edited 6 years ago by birgire (previous) (diff)
Note: See TracTickets for help on using tickets.