WordPress.org

Make WordPress Core

Opened 4 years ago

Closed 3 years ago

Last modified 15 months ago

#43479 closed defect (bug) (worksforme)

Theme detail text cutoff in RTL

Reported by: birgire Owned by: adamsilverstein
Milestone: Priority: normal
Severity: normal Version:
Component: Themes Keywords: has-screenshots
Focuses: rtl, administration Cc:

Description (last modified by birgire)

When viewing the theme detail in /wp-admin/themes.php, part of the text is cut off because of CSS. This happens when a RTL language is selected. Tested in Chrome Version 64.0.3282.186 on Win 10 desktop.

ps: I'm surprised I couldn't find tickets on this, but maybe my search foo failed me here ;-)

Attachments (3)

theme-detail-rtl.jpg (90.1 KB) - added by birgire 4 years ago.
theme-detail-ltr.jpg (91.1 KB) - added by birgire 4 years ago.
43479.png (213.8 KB) - added by man4toman 3 years ago.

Download all attachments as: .zip

Change History (17)

#1 @birgire
4 years ago

  • Description modified (diff)
  • Keywords has-screenshots added

#2 @adamsilverstein
4 years ago

Hi @birgire, thanks for the bug report. Can you confirm you still see this issue with all plugins disabled? Also, can you tell me what language you are using?

#3 @birgire
4 years ago

Hi @adamsilverstein, hopefully I'm not raising a false issue here ;-)

I tested this on an 4.9.4 install without plugins activated and default theme.

Also tested this on another 4.9.4 install, on different hosting.

The issues shows up in my Chrome for e.g. ar, ary and he_IL option values for the WPLANG dropdown.

I don't see this issue on Microsoft Edge 41.16299.248.0.

I wonder if somethings wrong with my Chrome (I disabled all extensions) and I don't see any console errors. I will have to look better into that.

#4 @birgire
4 years ago

The issue showed up when I tested on another labtop (Win10, Chrome 65.0) with another install at another hosting.

Shows up around viewport width 1350px.

This seems to be affected by overflow: auto; in:

.theme-overlay .theme-about {
    position: absolute;
    top: 49px;
    bottom: 57px;
    right: 0;
    left: 0;
    overflow: auto;
    padding: 2% 4%;
}

and e.g. the non-standard -webkit-paged-y seems to change it for the better.

But let's see if others can verify this issue.

#5 @adamsilverstein
4 years ago

  • Keywords needs-patch added
  • Owner set to adamsilverstein
  • Status changed from new to assigned

@birgire - Thanks for the additional debugging, language details and for testing on another laptop to confirm this is an issue. This should be enough information for work on a patch.

#6 @SergeyBiryukov
4 years ago

  • Milestone changed from Awaiting Review to 5.0

#7 @pento
3 years ago

  • Milestone changed from 5.0 to 5.1

#8 @adamsilverstein
3 years ago

  • Milestone changed from 5.1 to Future Release

Marking as future release until there is a patch to fix the issue.

#9 @man4toman
3 years ago

This problem is fixed on WordPress 5.0.3, I checked with Chrome 71.0 on Win10.

@man4toman
3 years ago

#10 @adamsilverstein
3 years ago

Thanks for confirming @man4toman! @birgire can you confirm this is resolved for you as well?

#11 @birgire
3 years ago

Thank you @man4toman for testing this and confirm that this is no longer an issue.

@adamsilverstein I just tested on 5.0.3 and don't see the issue anymore for RTL, so it looks like we can close this ticket, thanks.

#12 @adamsilverstein
3 years ago

  • Resolution set to fixed
  • Status changed from assigned to closed

#13 @desrosj
3 years ago

  • Milestone Future Release deleted

#14 @SergeyBiryukov
15 months ago

  • Keywords needs-patch removed
  • Resolution changed from fixed to worksforme

Just changing the resolution to worksforme for accuracy, as it's not quite clear when or where exactly this was fixed.

Note: See TracTickets for help on using tickets.