WordPress.org
Get WordPress

Make WordPress Core

Opened 7 years ago

Closed 7 years ago

Last modified 6 years ago

#43488 closed enhancement (fixed)

Debug backtrace doesn’t capture hook name for do_action_ref_array

Reported by: rarst's profile Rarst Owned by: sergeybiryukov's profile SergeyBiryukov
Milestone: 5.1 Priority: normal
Severity: normal Version:
Component: General Keywords: has-patch has-dev-note
Focuses: Cc:

Description

wp_debug_backtrace_summary() is currently hardcoded to treat do_action() and apply_filters() as special output case with invoked hook name appended.

It misses to do the same for do_action_ref_array()

Attachments (2)

Added_do_action_ref_array_to_hook_functions_in_trace_capture_.patch​ (898 bytes) - added by Rarst 7 years ago.
Added_to_hook_functions_in_trace_capture_.patch​ (925 bytes) - added by Rarst 7 years ago.

Download all attachments as: .zip

Change History (8)

@Rarst
7 years ago

#1 @Rarst
7 years ago

  • Keywords has-patch added

#2 @johnbillion
7 years ago

  • Milestone changed from Awaiting Review to 5.0
  • Version trunk deleted

There's apply_filters_ref_array() too.

@Rarst
7 years ago

#3 @Rarst
7 years ago

Ugh, I thought there was another one, but somehow managed to miss it in a quick search. :)

Patch updated.

#4 @SergeyBiryukov
7 years ago

  • Owner set to SergeyBiryukov
  • Resolution set to fixed
  • Status changed from new to closed

In 42820:

General: In wp_debug_backtrace_summary(), capture hook name for do_action_ref_array() and apply_filters_ref_array() as well.

Props Rarst.
Fixes #43488.

#5 @johnbillion
6 years ago

  • Milestone changed from 5.0 to 5.1

#6 @desrosj
6 years ago

  • Keywords has-dev-note added

This was mentioned in a 5.1 dev note: ​https://make.wordpress.org/core/2019/01/23/miscellaneous-developer-focused-changes-in-5-1/

Note: See TracTickets for help on using tickets.