WordPress.org

Make WordPress Core

Opened 2 years ago

Closed 2 years ago

Last modified 20 months ago

#43499 closed defect (bug) (fixed)

Document src/wp-admin/js/tags-box.js

Reported by: carolinegeven Owned by: atimmer
Milestone: 5.1 Priority: normal
Severity: normal Version: 5.1
Component: Taxonomy Keywords: has-patch
Focuses: javascript, docs Cc:

Description

Adds documentation to src/wp-admin/js/tags-box.js

To see the files changed: https://github.com/Yoast/wordpress-develop-mirror/pull/40

Please give props to: @atimmer, @carolinegeven, @andizer, @ireneyoast, @herregroen, @jjcomack

Attachments (3)

document-tags-box-js.patch (3.7 MB) - added by carolinegeven 2 years ago.
Document tags-box.js
document-tags-box-js.diff (9.0 KB) - added by carolinegeven 2 years ago.
Document tags-box.js
documents-tags-box.patch (9.0 KB) - added by DiedeExterkate 2 years ago.
Document tags-box.js

Change History (11)

@carolinegeven
2 years ago

Document tags-box.js

#1 @SergeyBiryukov
2 years ago

  • Component changed from General to Taxonomy
  • Milestone changed from Awaiting Review to 5.0

#2 @SergeyBiryukov
2 years ago

  • Keywords needs-refresh added

Hi @carolinegeven, thanks for the patch!

It appears to be created from the stable branch and contains 3.7 MB of unrelated changes :) Could you please refresh it from WordPress trunk?

@carolinegeven
2 years ago

Document tags-box.js

#3 @carolinegeven
2 years ago

@SergeyBiryukov Oops, sorry for that! Reuploaded the patch.

#4 @SergeyBiryukov
2 years ago

  • Keywords has-patch added; needs-refresh removed

#5 @birgire
2 years ago

In document-tags-box-js.diff I noticed a typo:

This line:

* @param {Event} e The window event to handle.


for:

$( 'input.newtag', ajaxtag ).keypress( function( event ) {


should be:

* @param {Event} event The window event to handle.

@DiedeExterkate
2 years ago

Document tags-box.js

#6 @DiedeExterkate
2 years ago

@kapteinbluf and I changed e to event and we've also changed all occurrences of @returns to @return

#7 @atimmer
2 years ago

  • Owner set to atimmer
  • Resolution set to fixed
  • Status changed from new to closed

In 42963:

Docs: Improve JSDoc for wp-admin/js/tags-box.js.

Props carolinegeven, andizer, ireneyoast, herregroen, jjcomack.
Fixes #43499.

#8 @johnbillion
20 months ago

  • Milestone changed from 5.0 to 5.1
Note: See TracTickets for help on using tickets.