WordPress.org

Make WordPress Core

Opened 3 years ago

Closed 2 years ago

#43508 closed defect (bug) (fixed)

Skip symlinked theme file tests if the links could not be created

Reported by: SergeyBiryukov Owned by: SergeyBiryukov
Milestone: 5.0 Priority: normal
Severity: normal Version: 4.7
Component: Themes Keywords: commit
Focuses: template Cc:

Description

The tests added in [38578] fail on Windows if there's not enough permissions to create symlinks:

Warning: symlink(): Cannot create symlink, error code(1314)

I guess they should be skipped if symlinks could not be created.

Change History (6)

#1 @SergeyBiryukov
3 years ago

  • Owner set to SergeyBiryukov
  • Resolution set to fixed
  • Status changed from new to closed

In 42812:

Tests: Skip symlinked theme file tests if the links could not be created.

Fixes #43508.

#2 @SergeyBiryukov
3 years ago

  • Version set to 4.7

#3 @SergeyBiryukov
3 years ago

In 42819:

Tests: Skip symlinked theme file tests if symlink() is not available, e.g. in PHP 5.2.x on Windows.

See #43508.

#4 @SergeyBiryukov
2 years ago

  • Resolution fixed deleted
  • Status changed from closed to reopened

Reopening for 5.0 or 5.0.1 consideration.

#5 @pento
2 years ago

  • Keywords commit added

👍🏻 on committing these to 5.0.

#6 @pento
2 years ago

  • Resolution set to fixed
  • Status changed from reopened to closed

In 43866:

Tests: Skip symlinked theme file tests if the links could not be created, or if symlink() is not available

Merges [42812,42819] to the 5.0 branch.

Props SergeyBiryukov.
Fixes #43508.

Note: See TracTickets for help on using tickets.