WordPress.org

Make WordPress Core

Opened 20 months ago

Closed 9 months ago

Last modified 9 months ago

#43522 closed enhancement (fixed)

Add aria-current to output of Walker_Page

Reported by: chetan200891 Owned by: SergeyBiryukov
Milestone: 5.1 Priority: normal
Severity: normal Version:
Component: Themes Keywords: has-patch 2nd-opinion dev-feedback
Focuses: accessibility Cc:
PR Number:

Description

From the reference of ticket #43191, Also need to add area-current to output of Walker_Page.

I think below modifications can help.

if ( $page->ID == $current_page ) {
        $atts['aria-current'] = 'page';
}

Attachments (1)

43522.diff (503 bytes) - added by wpzinc 19 months ago.

Download all attachments as: .zip

Change History (15)

This ticket was mentioned in Slack in #accessibility by chetan200891. View the logs.


20 months ago

This ticket was mentioned in Slack in #accessibility by afercia. View the logs.


19 months ago

#3 @afercia
19 months ago

  • Component changed from General to Themes
  • Keywords needs-patch added
  • Milestone changed from Awaiting Review to 5.0
  • Version trunk deleted

@wpzinc
19 months ago

#4 @lonelyvegan
18 months ago

  • Keywords has-patch added; needs-patch removed

Looks like this has a patch, so updating the keywords.

This ticket was mentioned in Slack in #accessibility by afercia. View the logs.


13 months ago

#6 @afercia
13 months ago

  • Milestone changed from 5.0 to 4.9.9

Discussed during today's accessibility bug scrub and we'd like to propose this ticket for 4.9.9 consideration.

#7 @pento
12 months ago

  • Milestone changed from 4.9.9 to 5.0.1

#8 @pento
10 months ago

  • Milestone changed from 5.0.1 to 5.0.2

#9 @pento
10 months ago

  • Milestone changed from 5.0.2 to 5.0.3

#10 @audrasjb
10 months ago

  • Keywords 2nd-opinion dev-feedback added

Patch looks fine on my side.

This ticket is triaged in milestone 5.0.3. It will needs commit and backport to the related branch.

This ticket was mentioned in Slack in #core by desrosj. View the logs.


10 months ago

#12 @desrosj
10 months ago

  • Milestone changed from 5.0.3 to 5.1

Going to punt this to 5.1. It is outside of the scope for 5.0.3 (block
editor bugs, regressions, and major bugs).

#13 @SergeyBiryukov
9 months ago

  • Owner set to SergeyBiryukov
  • Resolution set to fixed
  • Status changed from new to closed

In 44416:

Accessibility: Themes: use aria-current for the Walker_Page current link.

See [42808] for Walker_Nav_Menu.

The aria-current attribute is a simple, effective way to help assistive
technologies users orientate themselves within a list of items. Continues the
introduction in core of aria-current after [42440], [41683], [41359], and [41371].

Props chetan200891, wpzinc.
Fixes #43522.

Note: See TracTickets for help on using tickets.