WordPress.org
Get WordPress

Make WordPress Core

Opened 7 years ago

Closed 7 years ago

Last modified 3 years ago

#43523 closed task (blessed) (fixed)

Translator comment improvements for 5.1

Reported by: sergeybiryukov's profile SergeyBiryukov Owned by: sergeybiryukov's profile SergeyBiryukov
Milestone: 5.1 Priority: normal
Severity: normal Version:
Component: I18N Keywords:
Focuses: Cc:

Description

Background: #41974

Some translator comments have a number, but the corresponding string does not use numbered placeholders:

/* translators: 1: Site name */
printf( __( 'Links for %s' ), esc_attr( get_bloginfo( 'name', 'display' ) ) );

The comment should reference the actual placeholder instead:

/* translators: %s: site name */

Change History (6)

#1 @SergeyBiryukov
7 years ago

  • Owner set to SergeyBiryukov
  • Resolution set to fixed
  • Status changed from new to closed

In 42827:

I18N: Use the actual placeholder instead of a number in translator comments if the corresponding string does not use numbered placeholders.

Add missing translator comments in WP_Theme_Install_List_Table and wp_notify_postauthor().
Add missing commas in some translator comments.

Fixes #43523.

#2 @SergeyBiryukov
6 years ago

In 42983:

I18N: Correct placeholder references in a translator comment in wp_print_file_editor_templates().

Props afercia.
See #43523.

#3 @SergeyBiryukov
6 years ago

In 42984:

I18N: Use consistent pattern for placeholder references in a translator comment in media_upload_max_image_resize().

See #43523.

#4 @SergeyBiryukov
6 years ago

In 43090:

I18N: Use consistent pattern for placeholder references in a translator comment in wp-admin/update-core.php.

See #43523.

#5 @johnbillion
6 years ago

  • Milestone changed from 5.0 to 5.1

#6 @SergeyBiryukov
3 years ago

  • Summary changed from Translator comment improvements for 5.0 to Translator comment improvements for 5.1
Note: See TracTickets for help on using tickets.