Add $network_id to super admin functions.

[spacedmonkey]

Currently the super admin functions, do not allow you to pass a network id. For better support of multi network, we should add these params.

[johnjamesjacoby]

There might be an older ticket around here somewhere, but in the past we’ve always gotten stuck on the what “super” should imply, and that these functions are pulling double duty.

Usually we agree that it means install-wide, and not limited to any network at all. That leaves us longing for network_admin() type functions that have the same level of confusion with is_admin().

@flixos90 has started talking publicly about a “global” admin area, so maybe we are actually better off continuing the confusion and renaming “super” to “global” to match the inevitable.

So, I’m -1 on this change until we sort out an overall direction. But +1 on the functionality for sure.

[flixos90]

I partly agree with @johnjamesjacoby, however I would even go so far to say that we don't know what a super admin is. It technically is a network administrator, since they are stored in a network option - however, you can also set it via a global variable $super_admins, thus making it a true global administrator by that.

I generally don't have objections regarding the functionality itself, but another reason I think we should hold off is that our goal is to discourage usage of is_super_admin() and get_super_admins() completely (see my long-term favorite ticket #37616).

[jeremyfelt]

IMO, super admins are effectively global administrators. We should continue to work toward clarifying what a network admin is and how to identify them through some other mechanism (capabilities, likely) than is_super_admin().

I'd suggest closing this as a maybelater so that we can consider revisiting it one day.