WordPress.org

Make WordPress Core

Changes between Initial Version and Version 1 of Ticket #43545, comment 34


Ignore:
Timestamp:
04/12/2018 11:09:01 AM (22 months ago)
Author:
birgire
Comment:

Legend:

Unmodified
Added
Removed
Modified
  • Ticket #43545, comment 34

    initial v1  
    4646        - {{{test_anonymize_long_text()}}}.
    4747- Adds misisng full-stops to inline comments.
    48 - Adds doc parameter for "$raw_ip" and "$expected_result".
    49 - Makes the tests explicit in "test_anonymize_text", "test_anonymize_long_text", i.e. use assertEquals instead of assertNotEquals.
     48- Adds doc parameters for {{{$raw_ip}}} and {{{$expected_result}}}.
     49- Makes the tests explicit in {{{test_anonymize_text()}}}, {{{test_anonymize_long_text()}}}, i.e. use {{{assertEquals()}}} instead of {{{assertNotEquals()}}}.
    5050- Detailed {{{@return}}} for {{{data_wp_privacy_anonymize_ip()}}}.
    5151- Adds a file doc comment.
     
    5454- Adds the invalid IP testcase: {{{null -> 0.0.0.0}}}.
    5555- Adds the netmask testcase: {{{10.20.30.45/24 -> 10.20.30.0}}}.
    56 - Adds markTestSkipped in test_wp_privacy_anonymize_ip() if {{{inet_pton}}} and {{{inet_pton}}} are not available.
     56- Adds a {{{markTestSkipped}}} in {{{test_wp_privacy_anonymize_ip()}}} if {{{inet_pton}}} and {{{inet_pton}}} are not available.
    5757  Otherwise most of the IPv6 testcases, provided by {{{data_wp_privacy_anonymize_ip()}}}, would fail.
    5858  Another approach would be to adjust the testcases to to handle that.