WordPress.org
Get WordPress

Make WordPress Core

Changes between Version 4 and Version 5 of Ticket #43545, comment 8


Ignore:
Timestamp:
03/21/2018 12:44:10 PM (7 years ago)
Author:
birgire
Comment:

Legend:

Unmodified
Added
Removed
Modified

  • Ticket #43545, comment 8

    v4 v5  
    7878
    7979}}}
     80
     81
     82Note that the above version is currently suited for the {{{WP_Community_Events::get_unsafe_client_ip()}}} method, where it returns the full IP address if e.g.
     83the functions {{{inet_pton()}}} and {{{inet_ntop()}}} do not exists. That's intentional behaviour there, see e.g. #41083.
     84
     85I think we might need to adjust the full IP address return, with something else here. Also should the function return {{{false}}} or e.g. {{{WP_Error}}} instead on failure? But it would be great if this function could be re-used in e.g.  the {{{WP_Community_Events::get_unsafe_client_ip()}}} method.