Changes between Version 5 and Version 6 of Ticket #43545, comment 8
- Timestamp:
- 03/21/2018 12:45:57 PM (7 years ago)
Legend:
- Unmodified
- Added
- Removed
- Modified
-
Ticket #43545, comment 8
v5 v6 80 80 81 81 82 Note that the above version is currently suited for the {{{WP_Community_Events::get_unsafe_client_ip()}}} method, where it returns the full IP address if e.g. 83 the functions {{{inet_pton()}}} and {{{inet_ntop()}}} do not exists. That's intentional behaviour there, see e.g. #41083. 82 Note that the above version is currently suited for the {{{WP_Community_Events::get_unsafe_client_ip()}}} method, where it returns the full IP address if e.g. the functions {{{inet_pton()}}} and {{{inet_ntop()}}} do not exists. That's intentional behavior there, see e.g. #41083. 84 83 85 I think we might need to adjust the full IP address return , with something else here. Also should the function return {{{false}}} or e.g. {{{WP_Error}}} instead on failure? But it would be great if this function could be re-used in e.g. the {{{WP_Community_Events::get_unsafe_client_ip()}}} method.84 I think we might need to adjust the full IP address return here, with something else. Also should the function return {{{false}}} or e.g. {{{WP_Error}}} instead on failure? But it would be great if this function could be re-used in e.g. the {{{WP_Community_Events::get_unsafe_client_ip()}}} method.