E_WARNING: sprintf(): Too few arguments. [ wp-activate.php wp-activate.php (113) ]

[conner_bw]

We keep seeing E_WARNING: sprintf(): Too few arguments. [ wp-activate.php wp-activate.php (113) ] In our New Relic logs.

The problem is this line:

​Source

<?php
sprintf( '<a href="http://%s">%s</a>', $signup->domain )

Count the number of %s. Count the args. Should probably be:

<?php
sprintf( '<a href="http://%s">%s</a>', $signup->domain, $signup->domain )

Thanks.

[ocean90]

Introduced in [41579]. %s can be changed to a numbered placeholder.

[Thomas Vitale]

Changed %s to a numbered placeholder

[ocean90]

In 42844:

Multisite: Use a numbered placeholder in sprintf() for the site URL.

Fixes missing site domain in the link and a PHP warning.

Props Thomas Vitale, conner_bw.
See #41645.
Fixes #43568.

[ocean90]

In 42845:

Multisite: Use a numbered placeholder in sprintf() for the site URL.

Fixes missing site domain in the link and a PHP warning.

Merge of [42844] to the 4.9 branch.

Props Thomas Vitale, conner_bw.
See #41645, #43568.