WordPress.org

Make WordPress Core

Changes between Version 1 and Version 2 of Ticket #43573, comment 15


Ignore:
Timestamp:
10/13/2018 05:49:00 PM (10 months ago)
Author:
nielslange
Comment:

Legend:

Unmodified
Added
Removed
Modified
  • Ticket #43573, comment 15

    v1 v2  
    77`@media screen and ( min-width: 1600px )`
    88
    9 in Orlando.  Apparently, this leads to a design issue, as seen in [https://core.trac.wordpress.org/attachment/ticket/43573/Annotation%20on%202018-9-0%20(1).png: Annotation on 2018-9-0) (1).png]. Applying patch [https://core.trac.wordpress.org/attachment/ticket/43573/43573-1.diff: 43573-1.diff] instead of patch [https://core.trac.wordpress.org/attachment/ticket/43573/43573-2.diff: 43573-2.diff] should solved this issue, as seen in [https://core.trac.wordpress.org/attachment/ticket/43573/Annotation%20on%202018-9-0%20(2).png: Annotation on 2018-9-0) (2).png].
     9in Orlando.  Apparently, this leads to a design issue, as seen in [https://core.trac.wordpress.org/attachment/ticket/43573/Annotation%20on%202018-9-0%20(1).png Annotation on 2018-9-0) (1).png]. Applying patch [https://core.trac.wordpress.org/attachment/ticket/43573/43573-1.diff 43573-1.diff] instead of patch [https://core.trac.wordpress.org/attachment/ticket/43573/43573-2.diff 43573-2.diff] should solved this issue, as seen in [https://core.trac.wordpress.org/attachment/ticket/43573/Annotation%20on%202018-9-0%20(2).png Annotation on 2018-9-0) (2).png].
    1010
    11 To provide more context, while the latter statement `@media screen and ( min-width: 2300px ) ` technically overwrites the earlier statement `@media screen and ( min-width: 1600px ) {` the statement `.plugin-card:nth-child(3n+1) { ...}` and `.plugin-card:nth-child(3n) { .. }` won't be overwritten by the later statement. Alternativelly, you can apply [https://core.trac.wordpress.org/attachment/ticket/43573/43573-3.diff: 43573-3.diff], which I just created to overwrite the earlier definition in the later statement.
     11To provide more context, while the latter statement `@media screen and ( min-width: 2300px ) ` technically overwrites the earlier statement `@media screen and ( min-width: 1600px ) {` the statement `.plugin-card:nth-child(3n+1) { ...}` and `.plugin-card:nth-child(3n) { .. }` won't be overwritten by the later statement. Alternativelly, you can apply [https://core.trac.wordpress.org/attachment/ticket/43573/43573-3.diff 43573-3.diff], which I just created to overwrite the earlier definition in the later statement.
    1212
    1313Also, please also feel free to delete the attachment [https://core.trac.wordpress.org/attachment/ticket/43573/Annotation%20on%202018-9-0.png: Annotation on 2018-9-0.png], as I've I’ve uploaded it twice by accident.