Opened 7 years ago
Closed 6 years ago
#43573 closed enhancement (fixed)
Convert plugin cards into four columns for hi-res screens
Reported by: | nielslange | Owned by: | pento |
---|---|---|---|
Milestone: | 5.1 | Priority: | normal |
Severity: | normal | Version: | |
Component: | Plugins | Keywords: | has-patch |
Focuses: | ui, administration | Cc: |
Description (last modified by )
Plugin cards are displayed in a three column layout on screens set at 1600px or more on the /wp-admin/plugin-install.php
page. As 4K and 5K are becoming more popular, three columns is not a sufficient use of space anymore.
We should introduce a new media query to display the plugins in four columns for a screen width of 2000px and above.
Attachments (11)
Change History (29)
#3
@
7 years ago
- Description modified (diff)
- Keywords needs-testing added
- Summary changed from Enhance plugin list to Convert plugin cards into four columns for hi-res screens
#4
@
6 years ago
@danieltj I love this improvement. I wonder if we can get this included in WordPress 5.0 ?
#8
follow-up:
↓ 9
@
6 years ago
Tested and working good.
I've got two comments to potentially improve the patch:
- I think the breakpoint could be a bit higher than 2000px even, with the current breakpoint, the description is quite squashed. It seems that 2200 or even 2300 is a nicer breakpoint for readability.
- Currently, reordering the 15 plugins into 4 columns leaves a gap bottom right. Not sure what a CSS fix for that would be.
#9
in reply to:
↑ 8
@
6 years ago
Replying to jobthomas:
Tested and working good.
I've got two comments to potentially improve the patch:
- I think the breakpoint could be a bit higher than 2000px even, with the current breakpoint, the description is quite squashed. It seems that 2200 or even 2300 is a nicer breakpoint for readability.
- Currently, reordering the 15 plugins into 4 columns leaves a gap bottom right. Not sure what a CSS fix for that would be.
I've increased the breakpoint to 2300px and changed the number of items be the page from 30 to 36 to prevent the empty gap.
#10
@
6 years ago
Looking good @nielslange!
One minor tweak: you don't need to include the and ( max-width: 2299px )
media rule, as that block will be overridden, by the block after it.
#11
@
6 years ago
@pento As suggested, I just removed and ( max-width: 2299px )
and created a new patch.
#12
@
6 years ago
- Milestone changed from Awaiting Review to 5.0
- Owner set to pento
- Status changed from reopened to assigned
#15
@
6 years ago
@pento You might remember that we've discussed to change
@media screen and ( min-width: 1600px ) and ( max-width: 2299px )
to
@media screen and ( min-width: 1600px )
in Orlando. Apparently, this leads to a design issue, as seen in Annotation on 2018-9-0) (1).png. Applying patch 43573-1.diff instead of patch 43573-2.diff should solved this issue, as seen in Annotation on 2018-9-0) (2).png.
To provide more context, while the latter statement @media screen and ( min-width: 2300px )
technically overwrites the earlier statement @media screen and ( min-width: 1600px ) {
the statement .plugin-card:nth-child(3n+1) { ...}
and .plugin-card:nth-child(3n) { .. }
won't be overwritten by the later statement. Alternativelly, you can apply 43573-3.diff, which I just created to overwrite the earlier definition in the later statement.
Also, please also feel free to delete the attachment Annotation on 2018-9-0.png, as I've I’ve uploaded it twice by accident.
#16
follow-up:
↓ 17
@
6 years ago
- Resolution fixed deleted
- Status changed from closed to reopened
Tested patch 43573-3.diff It looks good to me! :)
Tested on 2100px screen, result 4 columns