Make WordPress Core

Opened 9 years ago

Closed 8 years ago

Last modified 8 years ago

#43594 closed enhancement (fixed)

Document $blogname, $blog_title, $errors, $domain, $path global in validate_another_blog_signup()

Reported by: mukesh27 Owned by: jeremyfelt
Priority: normal Milestone: 5.1
Component: Networks and Sites Version: 5.1
Severity: normal Keywords: has-patch
Cc: Focuses: docs, multisite

Description

global $blogname, $blog_title, $errors, $domain, $path are used but it is not mentioned in the documentation of the validate_another_blog_signup() function.

Attachments (1)

43594.patch​ (527 bytes ) - added by mukesh27 9 years ago.

Download all attachments as: .zip

Change History (7)

@mukesh27
9 years ago

#1 @mukesh27
9 years ago

  • Keywords has-patch added

This ticket was mentioned in ​Slack in #core by mukeshpanchal27. ​View the logs.


9 years ago

#3 @swissspidy
9 years ago

  • Component General → Networks and Sites
  • Focuses multisite added
  • Milestone Awaiting Review → 5.0
  • Type defect (bug) → enhancement

#4 @jeremyfelt
8 years ago

  • Owner set to jeremyfelt
  • Status new → reviewing

Thanks @mukesh27, this looks good. I'm going to change the wording just a bit in commit. Note for future documentation patches how the type, name, and description are aligned with spaces.

#5 @jeremyfelt
8 years ago

  • Resolution → fixed
  • Status reviewing → closed

In 43326:

Docs: Document globals in validate_another_blog_signup().

Props mukesh27.
Fixes #43594.

#6 @flixos90
8 years ago

  • Milestone 5.0 → 5.1
Note: See TracTickets for help on using tickets.