WordPress.org

Make WordPress Core

Opened 3 years ago

Closed 3 years ago

Last modified 3 years ago

#43594 closed enhancement (fixed)

Document $blogname, $blog_title, $errors, $domain, $path global in validate_another_blog_signup()

Reported by: mukesh27 Owned by: jeremyfelt
Milestone: 5.1 Priority: normal
Severity: normal Version: 5.1
Component: Networks and Sites Keywords: has-patch
Focuses: docs, multisite Cc:

Description

global $blogname, $blog_title, $errors, $domain, $path are used but it is not mentioned in the documentation of the validate_another_blog_signup() function.

Attachments (1)

43594.patch (527 bytes) - added by mukesh27 3 years ago.

Download all attachments as: .zip

Change History (7)

@mukesh27
3 years ago

#1 @mukesh27
3 years ago

  • Keywords has-patch added

This ticket was mentioned in Slack in #core by mukeshpanchal27. View the logs.


3 years ago

#3 @swissspidy
3 years ago

  • Component changed from General to Networks and Sites
  • Focuses multisite added
  • Milestone changed from Awaiting Review to 5.0
  • Type changed from defect (bug) to enhancement

#4 @jeremyfelt
3 years ago

  • Owner set to jeremyfelt
  • Status changed from new to reviewing

Thanks @mukesh27, this looks good. I'm going to change the wording just a bit in commit. Note for future documentation patches how the type, name, and description are aligned with spaces.

#5 @jeremyfelt
3 years ago

  • Resolution set to fixed
  • Status changed from reviewing to closed

In 43326:

Docs: Document globals in validate_another_blog_signup().

Props mukesh27.
Fixes #43594.

#6 @flixos90
3 years ago

  • Milestone changed from 5.0 to 5.1
Note: See TracTickets for help on using tickets.