WordPress.org

Make WordPress Core

Opened 8 years ago

Closed 5 years ago

#4360 closed enhancement (wontfix)

Allow commenting without giving an email address, but still requiring a name

Reported by: jameslab6 Owned by:
Milestone: Priority: normal
Severity: minor Version: 2.9
Component: Administration Keywords: close
Focuses: Cc:

Description

There is a Discussion option "Comment author must fill out name and e-mail". I want every commenter to have a name, but I don't care about them giving an email address (nobody gives real addresses anyway). So I think these two requirements should be decoupled.

Attachments (1)

4360.diff (12.5 KB) - added by rob1n 8 years ago.

Download all attachments as: .zip

Change History (19)

comment:1 @foolswisdom8 years ago

  • Milestone changed from 2.3 to 2.4

comment:2 follow-up: @rob1n8 years ago

  • Milestone changed from 2.4 to 2.3
  • Owner changed from anonymous to rob1n

How about we change the logic so that we provide checkboxes for what information needs to be included?

So we have checkboxes for Name, Email and URL. The user can selectively choose what he wants filled out.

comment:3 in reply to: ↑ 2 @jameslab68 years ago

Replying to rob1n:

How about we change the logic so that we provide checkboxes for what information needs to be included?

So we have checkboxes for Name, Email and URL. The user can selectively choose what he wants filled out.

Yes, that sounds perfect.

@rob1n8 years ago

comment:4 @rob1n8 years ago

  • Keywords has-patch needs-testing added

comment:5 @rob1n8 years ago

  • Status changed from new to assigned

comment:6 @Stargazer8 years ago

Email is often used for gravatar and notification stuff. So I fully agree with the checkbox solution.

comment:7 @ryan7 years ago

  • Milestone changed from 2.3 to 2.4 (next)

comment:8 @rob1n7 years ago

  • Owner rob1n deleted
  • Status changed from assigned to new

comment:9 @spencerp7 years ago

I'm willing to test this out if someone can provide an updated patch for it? I'm not a coder, so I'm not sure how this "code" works? Or, unless everyone thinks it's not necessary anymore, maybe just close this ticket out and someone create a plugin for it instead? Just was wondering.

comment:10 @spencerp7 years ago

But as for testing this out on latest trunk, here's what I got:

Here's what I got so far:

a) Options don't "stick". I selected to use just commenter name, and hit
update options button. It's not sticking, the check mark isn't "in" the
check box after hitting update options... resulting in b)
b) After submitting the comment, I get following error message: "Error:
please enter a valid email address."
c) In wp-comments.post.php file..

this line needs to changed from:
wp_die( ( 'Error: please complete the URL field.' );

to (get rid of syntax error or whatever):
wp_die( ( 'Error: please complete the URL field.' ) );

comment:11 @spencerp7 years ago

Oops, forgot code blocks above.

this line needs to changed from:

wp_die( __( 'Error: please complete the URL field.' );

to (get rid of syntax error or whatever):

wp_die( __( 'Error: please complete the URL field.' ) );

comment:12 @spencerp7 years ago

Can someone do something with this one? I COULD make a partial up-to-date patch for this, it's just where I'd have to make the patch for the update the WordPress version that'd throw me off. I'm not sure how to do that. The other thing that I'm not sure about, is, the whole thing where the current patch wasn't having the "option stick"? =/

I tested out the current patch, but when choosing "name" for required rather then email address, it threw an error and the option wasn't "sticking". I put the check mark in the box for "Name" or whatever, hit update button and the check mark was no longer in the check box and the option wasn't "sticking" like supposed too. Hence for getting the error I mentioned above.

Can someone (with code wisdom) maybe do an up-to-date patch for this and perhaps figure out why the patch wasn't working? Like I said, I could make an up-to-date partial patch. But I need someone with more coding experience to figure out the rest...

comment:13 @westi7 years ago

  • Milestone 2.5 deleted
  • Resolution set to wontfix
  • Status changed from new to closed

Marking as wontfix.

We're not going to add extra options here.

If you really want this functionality you can implement it in a plugin which works with the core option set to allow comments without email_address and name and the plugin doing the check for a name on the preprocess_comment hook and using wp_die if it's not supplied.

comment:14 follow-up: @WK15 years ago

This bug (or "feature enhancement", if you prefer) definitely should be fixed. It is unfortunate that it has stood for 2 years without being fixed. Most of that time with a patch in hand.

"If you really want this functionality you can implement it in a plugin..."

Requiring a plugin to alter basic settings is silly. Placing two options in one checkbox is also silly.

comment:15 @WK15 years ago

  • Resolution wontfix deleted
  • Status changed from closed to reopened
  • Version set to 2.8.4

I wasn't going to reopen this bug, but then I realized that it was only one developer who decided to ignore it, despite popular approval. Perhaps the environment has changed. Perhaps now, this bug might be fixed if the devs were more aware of it.

comment:16 @strider725 years ago

  • Version changed from 2.8.4 to 2.9

Whatever the case may be, no new features in 2.8.4

comment:17 in reply to: ↑ 14 @scribu5 years ago

  • Keywords close added; has-patch needs-testing removed

Replying to WK1:

This bug (or "feature enhancement", if you prefer) definitely should be fixed. It is unfortunate that it has stood for 2 years without being fixed. Most of that time with a patch in hand.

"If you really want this functionality you can implement it in a plugin..."

Requiring a plugin to alter basic settings is silly. Placing two options in one checkbox is also silly.

Ok, now it's 2 developers. WordPress has a policy of "don't add options that aren't absolutely necessary". That's what plugins are for.

Most users won't need that much control over what is and what isn't required.

comment:18 @westi5 years ago

  • Resolution set to wontfix
  • Status changed from reopened to closed

As before - WONTFIX.

Note: See TracTickets for help on using tickets.