WordPress.org
Get WordPress

Make WordPress Core

Opened 8 years ago

Closed 5 years ago

Last modified 5 years ago

#43639 closed defect (bug) (fixed)

wp_terms_checklist post_id argument is null, should be 0

Reported by: tareiking Owned by: SergeyBiryukov
Priority: normal Milestone: 5.9
Component: Taxonomy Version:
Severity: normal Keywords: has-patch commit
Cc: Focuses: administration

Description

In includes/class-wp-posts-list-table.php we call wp_terms_checklist with post_id set to null.

wp_terms_checklist post_id argument should be an int and 0 is used as the default elsewhere (ie: ajax-actions.php).

Reference: https://core.trac.wordpress.org/browser/trunk/src/wp-admin/includes/class-wp-posts-list-table.php#L1543

Change History (8)

#1 @pento
8 years ago

  • Version trunk

This ticket was mentioned in ​Slack in #core-site-health by hareesh-pillai. ​View the logs.
6 years ago

#3 @SergeyBiryukov
6 years ago

  • Component General → Taxonomy
  • Keywords needs-patch added

This ticket was mentioned in ​PR #1173 on ​WordPress/wordpress-develop by ​donmhico.
5 years ago #4

  • Keywords has-patch added; needs-patch removed

Pass 0 instead of null on wp_terms_checklist() for consistency.

Trac ticket: https://core.trac.wordpress.org/ticket/43639

#5 @donmhico
5 years ago

Thanks for the ticket @tareiking. I've attached a PR that fixes this issue.

#6 @jrf
5 years ago

  • Keywords commit added
  • Milestone Awaiting Review → 5.9

Reviewed and found valid. This patch should be committed.

As per the ​docs for the wp_terms_checklist() function, the default value is integer 0, not null.

#7 @SergeyBiryukov
5 years ago

  • Owner set to SergeyBiryukov
  • Resolution → fixed
  • Status new → closed

In 51520:

Taxonomy: Pass correct default value for $post_id to wp_terms_checklist() in the posts list table.

This matches the documented type of the $post_id argument and is consistent with other instances of wp_terms_checklist() calls.

Per the function documentation, the default value is integer 0, not null.

Follow-up to [13535].

Props tareiking, donmhico, jrf.
Fixes #43639.

Note: See TracTickets for help on using tickets.