WordPress.org

Make WordPress Core

Opened 2 years ago

Closed 2 years ago

#43662 closed defect (bug) (duplicate)

No reset password link preset in some providers

Reported by: Julius123 Owned by:
Milestone: Priority: normal
Severity: normal Version:
Component: Login and Registration Keywords:
Focuses: Cc:

Description

The password reset email is missing the rest link in some cases. It seems to be because of an inconsistency with email providers with regards to text vs html emails. The fix is below in login.php

$message .= '<' . network_site_url( "wp-login.php?action=rp&key=$key&login=" . rawurlencode( $user_login ), 'login' ) . ">\r\n";

should be

$message .= '(' . network_site_url( "wp-login.php?action=rp&key=$key&login=" . rawurlencode( $user_login ), 'login' ) . ")\r\n";

Note that < >has been replaced with ( )

Cheers

Julius

Attachments (1)

Screen Shot 2018-03-29 at 12.59.38.png (71.9 KB) - added by Julius123 2 years ago.
login.php

Download all attachments as: .zip

Change History (3)

#1 @mattkeys
2 years ago

  • Keywords needs-patch dev-feedback needs-testing added

Hello Julius123,

A good next step here would be to submit a patch (.diff file) with your changes. There are a variety of methods out there for generating this file. Your can use SVN or GIT. Read more here: https://make.wordpress.org/core/handbook/tutorials/trac/submitting-a-patch/

#2 @SergeyBiryukov
2 years ago

  • Keywords needs-patch dev-feedback needs-testing removed
  • Milestone Awaiting Review deleted
  • Resolution set to duplicate
  • Status changed from new to closed

Hi @Julius123, welcome to WordPress Trac!

Thanks for the report, we're already tracking this issue in #23578 and #21095. Also related: #43206.

Note: See TracTickets for help on using tickets.