Opened 7 years ago
Closed 6 years ago
#43675 closed enhancement (fixed)
UI adjustments for comments and posts timestamp inputs . Make the input text look centralized.
Reported by: | birgire | Owned by: | desrosj |
---|---|---|---|
Milestone: | 5.2 | Priority: | low |
Severity: | minor | Version: | |
Component: | General | Keywords: | has-screenshots has-patch commit |
Focuses: | ui, administration | Cc: |
Description
The timestamp inputs on the post- and comment edit screens are not text centralized, like they are in the quick-edit forms for posts.
It looks like this can fixed by e.g. adjusting the margins/widths/paddings. The quick-edit forms are not using text-align
as center
though.
These fields are:
#aa
(year),#mm
(month),#jj
(day),#hh
(hour)#mm
(minutes)
under #timestampdiv
.
Attachments (11)
Change History (23)
#2
@
7 years ago
- Keywords needs-patch 2nd-opinion added
- Priority changed from normal to low
- Type changed from defect (bug) to enhancement
This ticket was mentioned in Slack in #design by karmatosed. View the logs.
6 years ago
#7
@
6 years ago
Talked about this in #design and we're a +1 for making it consistent.
Has this been tested on a couple browsers? I know input styling can get a little weird.
#8
@
6 years ago
Thanks for the review @melchoyce
For comparison I checked how it's in the block editor, for WordPress 5.1.1:
- The screenshot is in block-editor-has-text-aligned-date-time-input-in-version-5-1-1.jpg.
- There the number fields, that represent date-time, use
text-align: center;
to align the numbers. - Same for rtl, as seen in screenshot block-editor-has-text-aligned-date-time-input-in-version-5-1-1-rtl.jpg.
I had a look at it in Microsoft Edge, for WordPress 5.1.1, where the quick-edit date-time number inputs also look center-aligned but not on the post- and comment edit's screens:
- quick-edit-post-version-5-1-1-in-edge-browser.jpg
- classical-editor-edit-post-version-5-1-1-in-edge-browser.jpg
- edit-comment-version-5-1-1-in-edge-browser.jpg
Having a consistent alignment on the date-time input fields would be great.
#9
@
6 years ago
@melchoyce what are your thoughts on this being ready for 5.2 beta 1 in a bit over a day?
I've fixed the alignment in this patch.