WordPress.org

Make WordPress Core

Opened 3 years ago

Closed 3 years ago

#43675 closed enhancement (fixed)

UI adjustments for comments and posts timestamp inputs . Make the input text look centralized.

Reported by: birgire Owned by: desrosj
Milestone: 5.2 Priority: low
Severity: minor Version:
Component: General Keywords: has-screenshots has-patch commit
Focuses: ui, administration Cc:

Description

The timestamp inputs on the post- and comment edit screens are not text centralized, like they are in the quick-edit forms for posts.

It looks like this can fixed by e.g. adjusting the margins/widths/paddings. The quick-edit forms are not using text-align as center though.

These fields are:

  • #aa (year),
  • #mm (month),
  • #jj (day),
  • #hh (hour)
  • #mm (minutes)

under #timestampdiv.

Attachments (11)

post-timestamp-edit-before.JPG (12.8 KB) - added by birgire 3 years ago.
post-timestamp-edit-after.jpg (13.0 KB) - added by birgire 3 years ago.
comment-timestamp-edit-before.jpg (12.8 KB) - added by birgire 3 years ago.
comment-timestamp-edit-after.jpg (12.7 KB) - added by birgire 3 years ago.
post-timestamp-quick-edit.jpg (14.1 KB) - added by birgire 3 years ago.
43675.diff (319 bytes) - added by jainnidhi 3 years ago.
I've fixed the alignment in this patch.
block-editor-has-text-aligned-date-time-input-in-version-5-1-1.jpg (13.4 KB) - added by birgire 3 years ago.
block-editor-has-text-aligned-date-time-input-in-version-5-1-1-rtl.jpg (13.5 KB) - added by birgire 3 years ago.
quick-edit-post-version-5-1-1-in-edge-browser.jpg (14.2 KB) - added by birgire 3 years ago.
classical-editor-edit-post-version-5-1-1-in-edge-browser.jpg (22.2 KB) - added by birgire 3 years ago.
edit-comment-version-5-1-1-in-edge-browser.jpg (20.1 KB) - added by birgire 3 years ago.

Download all attachments as: .zip

Change History (23)

#1 @SergeyBiryukov
3 years ago

  • Milestone changed from Awaiting Review to 5.0

#2 @danieltj
3 years ago

  • Keywords needs-patch 2nd-opinion added
  • Priority changed from normal to low
  • Type changed from defect (bug) to enhancement

@jainnidhi
3 years ago

I've fixed the alignment in this patch.

#3 @jainnidhi
3 years ago

  • Keywords has-patch added; needs-patch removed

#4 @pento
3 years ago

  • Milestone changed from 5.0 to 5.1

#5 @pento
3 years ago

  • Keywords needs-design added
  • Milestone changed from 5.1 to 5.2

Needs design review.

This ticket was mentioned in Slack in #design by karmatosed. View the logs.


3 years ago

#7 @melchoyce
3 years ago

Talked about this in #design and we're a +1 for making it consistent.

Has this been tested on a couple browsers? I know input styling can get a little weird.

#8 @birgire
3 years ago

Thanks for the review @melchoyce

For comparison I checked how it's in the block editor, for WordPress 5.1.1:

I had a look at it in Microsoft Edge, for WordPress 5.1.1, where the quick-edit date-time number inputs also look center-aligned but not on the post- and comment edit's screens:

Having a consistent alignment on the date-time input fields would be great.

#9 @desrosj
3 years ago

@melchoyce what are your thoughts on this being ready for 5.2 beta 1 in a bit over a day?

#10 @melchoyce
3 years ago

  • Keywords commit added; ui-feedback 2nd-opinion needs-design removed

Looks good to me!

#11 @desrosj
3 years ago

  • Owner set to desrosj
  • Status changed from new to reviewing

#12 @desrosj
3 years ago

  • Resolution set to fixed
  • Status changed from reviewing to closed

In 44945:

Administration: Ensure consistent alignment for time and date fields across edit screens.

This change ensures that the values of time and date fields for comments and posts (both Classic Editor and quick edit) are consistently aligned in the center of the input fields. The block editor already enforces this alignment separately.

Props birgire, jainnidhi, melchoyce.
Fixes #43675.

Note: See TracTickets for help on using tickets.