WordPress.org
Get WordPress

Make WordPress Core

Opened 7 years ago

Closed 6 years ago

Last modified 6 years ago

#43679 closed enhancement (fixed)

Add $this to found_users_query filter

Reported by: spacedmonkey's profile spacedmonkey Owned by: sergeybiryukov's profile SergeyBiryukov
Milestone: 5.1 Priority: normal
Severity: normal Version: 3.2
Component: Users Keywords: has-patch
Focuses: Cc:

Description

Add more context to the found_users_query filter, by adding this to the filter.

Attachments (2)

43679.diff​ (823 bytes) - added by spacedmonkey 7 years ago.
43679.2.diff​ (993 bytes) - added by spacedmonkey 7 years ago.

Download all attachments as: .zip

Change History (11)

@spacedmonkey
7 years ago

#1 @SergeyBiryukov
7 years ago

  • Milestone changed from Awaiting Review to 5.0

#2 @danieltj
7 years ago

  • Keywords needs-refresh added

The patch needs a refresh to indent the doc-block items properly so they align as per WPCS.

@spacedmonkey
7 years ago

#3 @spacedmonkey
7 years ago

  • Keywords needs-refresh removed

@danieltj Thanks for the feedback. I have updated the patch, to improve the docs.

#4 @SergeyBiryukov
6 years ago

  • Milestone changed from 5.0 to 4.9.9
  • Owner set to SergeyBiryukov
  • Status changed from new to reviewing

#5 @SergeyBiryukov
6 years ago

  • Resolution set to fixed
  • Status changed from reviewing to closed

In 43660:

Users: Pass the current WP_User_Query instance to found_users_query filter.

Props spacedmonkey.
Fixes #43679.

#6 @SergeyBiryukov
6 years ago

  • Keywords fixed-major added
  • Resolution fixed deleted
  • Status changed from closed to reopened

Reopening for 4.9.9 consideration.

#7 @pento
6 years ago

  • Keywords fixed-major removed
  • Milestone changed from 4.9.9 to 5.1

Moving to 5.1, comment added in [43660] needs to be updated.

#8 @SergeyBiryukov
6 years ago

  • Resolution set to fixed
  • Status changed from reopened to closed

In 44348:

Docs: Update @since tag for the WP_User_Query instance added to found_users_query filter in [43660].

Fixes #43679.

#9 @SergeyBiryukov
6 years ago

In 44410:

Docs: Correct @since tag for users_pre_query filter added in [44373].

Revert unintended change to the @since tag for the WP_User_Query instance added to found_users_query filter in [43660].

See #44169, #43679.

Note: See TracTickets for help on using tickets.