Opened 3 years ago
Last modified 3 weeks ago
#43697 reviewing enhancement
Add theme update counter in admin theme menu item
Reported by: |
|
Owned by: |
|
---|---|---|---|
Milestone: | 5.8 | Priority: | normal |
Severity: | normal | Version: | |
Component: | Themes | Keywords: | has-patch has-screenshots dev-feedback needs-testing |
Focuses: | ui, administration | Cc: |
Description
Add theme update counter in admin theme menu item as we show for plugin menu item.
Attachments (6)
Change History (15)
#6
@
3 weeks ago
- Focuses ui added
@joyously I think using update-plugins
as class name is not very intuitive, but at the moment correct.
The network menu is using it too:
https://github.com/WordPress/WordPress/blob/b3b8942dfcb451eddb5559b63c1043fce5d9449e/wp-admin/network/menu.php#L65
We could either use it here too or add the class name to the CSS, because at the moment it does not exist:
https://github.com/WordPress/WordPress/search?q=update-themes
@mukesh27 Looking at the patch and the screenshot it shows an inconsistent behavior: The badge is added to the first submenu item instead of the main menu item ("Appearance"), like it is seen for the "Plugins" menu item.
I would vote for using the same design as for Plugins (which is also used in a multisite):
https://github.com/WordPress/WordPress/blob/b3b8942dfcb451eddb5559b63c1043fce5d9449e/wp-admin/network/menu.php#L59-L79
@
3 weeks ago
Updated patch. Count is added to "appearance" now and is using the correct class names and caps.
#7
@
3 weeks ago
I am still experiencing a strange behavior. There is a paid theme in my test environment with available update, but the notice "Automatic update is unavailable for this theme."
After leaving the themes.php
page the count is changing from 7 to 6. On all admin pages it stays on 6. Just on update-core.php
it is showing 7 again.
Why does your code use the
update-plugins
capability and class name?This used to work. Can you look back at older versions for that code?