Changes between Initial Version and Version 1 of Ticket #43731, comment 10
- Timestamp:
- 06/17/2018 07:58:22 AM (7 years ago)
Legend:
- Unmodified
- Added
- Removed
- Modified
-
Ticket #43731, comment 10
initial v1 2 2 3 3 I've uploaded a new patch that's based on the latest trunk. 4 5 It is still based on Omar's patch in #44371 as that's required for this to work. His changes there are included in my patch to allow everything to actually work and be testable. Most of the comment changes are from that patch and have simply been moved from the var declaration to the actual assignment. 6 7 The only comment change should be removing the `@output` tag from the embed.js file as this can't be build by webpack due to the issue linked in the comment. I've expanded that comment to explain this.