WordPress.org

Make WordPress Core

Opened 2 years ago

Last modified 2 years ago

#43736 new defect (bug)

Audio continues to play in Media Modal after close

Reported by: bahia0019 Owned by:
Milestone: Awaiting Review Priority: normal
Severity: normal Version: 4.9.5
Component: Media Keywords:
Focuses: Cc:

Description

When previewing an audio file in the Media Library modal, if you click Close or Escape, the audio continues to play.
I haven't tested with Video, but I am assuming audio continues as well.

Change History (2)

#1 @bahia0019
2 years ago

I couldn't figure out how to properly diff the SVN I checked out, but my patch is:

Adding the following to wp-includes/js/media-views.js line 4399.

$('.wp-media-wrapper').remove();

#2 @adamsilverstein
2 years ago

@bahia0019 Thanks for the bug report and proposed fix! I'll take a look.

Please note that you can now use git instead of svn when creating patches, perhaps that will make it easier for you? ​https://make.wordpress.org/meta/handbook/documentation/contributing-with-git/. Another alternative is using our grunt patch command: ​https://www.npmjs.com/package/grunt-patch-wordpress.

Note: See TracTickets for help on using tickets.