WordPress.org

Make WordPress Core

Opened 2 months ago

Last modified 2 months ago

#43755 reviewing defect (bug)

CS: Fix violations for wp-includes/canonical.php

Reported by: jipmoors Owned by: netweb
Milestone: 5.0 Priority: normal
Severity: normal Version:
Component: Canonical Keywords: has-patch
Focuses: coding-standards Cc:

Description

Started working on this at WordCamp London contributor day.

Attachments (1)

43755-fix-coding-standards.patch (13.9 KB) - added by jipmoors 2 months ago.

Download all attachments as: .zip

Change History (5)

#1 @netweb
2 months ago

  • Component changed from General to Canonical
  • Keywords needs-patch added

#2 @netweb
2 months ago

  • Milestone changed from Awaiting Review to 5.0
  • Owner set to netweb
  • Status changed from new to reviewing

#3 @jipmoors
2 months ago

Have made some additional changes to make sure wp_parse_url is used on all occasions.

Also to be able to ignore the prepare statement sniff, have made sure all parts of the query have been prepared. I can imagine this could be a separate patch or at least be a separate commit, but it was in line of fixing the code sniff.

Have ran all unit tests and did not encounter any problems.

#4 @jipmoors
2 months ago

  • Keywords has-patch added; needs-patch removed
Note: See TracTickets for help on using tickets.